Skip to content

Commit

Permalink
Fix error in template
Browse files Browse the repository at this point in the history
  • Loading branch information
macumber committed Jul 22, 2016
1 parent 7adf1ea commit 462ae9e
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7437,15 +7437,6 @@ OS:Construction,
, !- Surface Rendering Name
{9c2e9d3e-294f-43b6-a35a-50ee1f5a6da4}; !- Layer 1

OS:SpaceInfiltration:EffectiveLeakageArea,
{fa1b2cef-5376-4b21-8ebc-9ede6f08ab69}, !- Handle
Space Infiltration Effective Leakage Area 1, !- Name
, !- Space or SpaceType Name
, !- Schedule Name
100, !- Effective Air Leakage Area {cm2}
0.1, !- Stack Coefficient
0.1; !- Wind Coefficient

OS:Site,
{67954095-e568-4057-a467-6d726fa7832a}, !- Handle
Site 1, !- Name
Expand Down
8 changes: 8 additions & 0 deletions openstudiocore/src/energyplus/ForwardTranslator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ Workspace ForwardTranslator::translateModelPrivate( model::Model & model, bool f
}
}

// remove orphan loads
for (SpaceLoad spaceLoad : model.getModelObjects<SpaceLoad>()){
if ((!spaceLoad.space()) && (!spaceLoad.spaceType())){
LOG(Warn, spaceLoad.briefDescription() << " is not associated with a Space or SpaceType, it will not be translated.");
spaceLoad.remove();
}
}

// next thing to do is combine all spaces in each thermal zone
// after this each zone will have 0 or 1 spaces and each space will have 0 or 1 zone
for (ThermalZone thermalZone : model.getConcreteModelObjects<ThermalZone>()){
Expand Down

12 comments on commit 462ae9e

@macumber
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanweaver this fixes the sanity test

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (macumber) - x86_64-MacOS-10.10-clang: OK (2394 of 2447 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (macumber) - i386-Windows-7-VisualStudio-12: OK (2420 of 2447 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed (2146 of 2447 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2364 of 2447 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - x86_64-MacOS-10.10-clang: OK (2391 of 2447 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - i386-Windows-7-VisualStudio-12: Tests Failed (2175 of 2447 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - Win64-Windows-7-VisualStudio-12: Tests Failed (2150 of 2447 tests passed, 0 test warnings)

Build Badge Test Badge

@asparke2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macumber This change breaks the prototype buildings, where there are a lot of WaterUse:Equipment objects not assigned to spaces. This also will break a lot of user models, since you've never been required to assign WaterUse:Equipment to spaces. I suggest adding an exception to skip over removing orphaned WaterUse:Equipment. @phylroy FYI

Please sign in to comment.