Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power control #375

Open
wants to merge 74 commits into
base: develop
Choose a base branch
from
Open

Power control #375

wants to merge 74 commits into from

Conversation

dzalkind
Copy link
Collaborator

@dzalkind dzalkind commented Sep 3, 2024

Description and Purpose

Add power control to ROSCO. Details to be included in documentation of new features.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

dzalkind and others added 30 commits March 27, 2024 14:08
GB efficiency reduces LSS to HSS
GEN reduces HSS to generator electrical output
We apply the GenTq at the HSS
Examples/05_openfast_sim.py Outdated Show resolved Hide resolved
Examples/17b_zeromq_multi_openfast.py Outdated Show resolved Hide resolved
docs/source/api_change.rst Outdated Show resolved Hide resolved
@@ -122,12 +122,13 @@ A complete list of examples is given below:
.. automodule:: 17b_zeromq_multi_openfast
.. automodule:: 18_pitch_offsets
.. automodule:: 19_update_discon_version
.. automodule:: 20_active_wake_control
.. .. automodule:: 20_active_wake_control
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is commenting out Example 20 here intentional?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I'll revert it until I come up with a better solution. This example is well documented in the python script, but it's not in the rst format. I'm slowly working on expanding the example documentation. I wonder if we can point to another rst file within this automodule set up?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The easiest way would be to just add the needed rst text between automodule 19 and 21. Not sure if it would match the formatting but should be OK at this stage.

description: Open loop control mode {0 - no open loop control, 1 - open loop control vs. time, 2 - open loop control vs. wind speed}
OL_BP_FiltFreq:
<<: *real
description: Open loop control mode {0 - no open loop control, 1 - open loop control vs. time, 2 - open loop control vs. wind speed}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the wrong description.

@@ -502,6 +533,15 @@ ControlParameters:
Ind_YawRate:
<<: *integer
description: The column in OL_Filename that contains the generator torque in Nm
Ind_R_Speed:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description of Ind_R_Speed, Torque and pitch needs to be updated.

description: WSE Operational state (0- not operating, 1-operating)
WE_Op_Last:
<<: *integer
description: WSE Operational state (0- not operating, 1-operating)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description needs to be updated.

rosco/test/test_examples.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants