Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kva back to transformer #172

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

NicolasGensollen
Copy link
Member

Attempt to address the KVA issues described in #160

@tarekelgindy, this PR impacts basically all parsers so we probably should be very careful and test it (smartd-ds and others) before eventually merging.

NOTES:

  • I didn't update the DEW reader since it is not working anyway
  • I did my best for the Gridlab-D parsers and the Ephasor writer but I'm not familiar with them, so double checking seems like a good idea

Copy link
Contributor

@tarekelgindy tarekelgindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to merge some of the other branches into master before we merge this one. The changes look good but there are some new modifications to the regulator writer in CYME (for instance) that should be merged first.

@codecov-io
Copy link

Codecov Report

Merging #172 into master will decrease coverage by 0.02%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
- Coverage   43.96%   43.94%   -0.03%     
==========================================
  Files          74       74              
  Lines       16473    16383      -90     
==========================================
- Hits         7243     7200      -43     
+ Misses       9230     9183      -47
Impacted Files Coverage Δ
ditto/models/winding.py 100% <ø> (ø) ⬆️
ditto/writers/json/write.py 93.47% <ø> (ø) ⬆️
ditto/readers/json/read.py 88.88% <ø> (ø) ⬆️
ditto/readers/synergi/read.py 0% <0%> (ø) ⬆️
ditto/readers/opendss/read.py 60.56% <100%> (+0.26%) ⬆️
ditto/writers/ephasor/write.py 90.41% <100%> (ø) ⬆️
ditto/models/regulator.py 100% <100%> (ø) ⬆️
ditto/writers/gridlabd/write.py 84.98% <100%> (ø) ⬆️
ditto/models/powertransformer.py 100% <100%> (ø) ⬆️
ditto/readers/cyme/read.py 62.13% <16.66%> (+0.26%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b7e894...248552a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants