improve CYME reader and DSS writer #399
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not sure why this is here, just printing cable sectionID
- cannot parse a list of objects though it was taking a obj_list as input; - it would only parse the first value in the list; - now it takes in a string instead of list of string - also improved notes/documentation
was not handling missing "wires" in a Line
was trying to log objects ?
was added up multiple loads which could lead to 12 phase loads for example, with 4 LoadModelIDs and 3 phases
|
Thanks for making a PR! |
- was only replacing dot or space with under score - now handling all special characters (which openDSS cannot handle)
|
@kdheepak a bunch of openDSS reader tests are failing on NREL/master branch: tests/readers/opendss/Capacitors/test_capacitor_connectivity.py::test_capacitor_connectivity FAILED [ 81%]
tests/readers/opendss/Capacitors/test_capacitor_kvar.py::test_capacitor_kvar PASSED [ 81%]
tests/readers/opendss/Lines/test_fuses.py::test_fuses FAILED [ 82%]
tests/readers/opendss/Lines/test_line_connectivity.py::test_line_connectivity FAILED [ 82%]
tests/readers/opendss/Lines/test_line_length.py::test_line_length FAILED [ 83%]
tests/readers/opendss/Lines/test_linecodes.py::test_linecodes FAILED [ 84%]
tests/readers/opendss/Lines/test_linegeometries.py::test_linegeometries XFAIL (This test fails when opendssdirect v0.5.0 is used.) [ 84%]
tests/readers/opendss/Lines/test_switches.py::test_switches FAILED [ 85%]
tests/readers/opendss/Loads/test_load_p_and_q.py::test_load_p_and_q PASSED [ 85%]
tests/readers/opendss/Loads/test_loads.py::test_loads FAILED [ 86%]
tests/readers/opendss/Nodes/test_nodes.py::test_nodes PASSED [ 87%]
tests/readers/opendss/Powersource/test_powersource.py::test_powersource FAILED [ 87%]
tests/readers/opendss/Regulators/test_regulators.py::test_regulators FAILED [ 88%]
tests/readers/opendss/Transformers/test_transformer_kv.py::test_transformer_kv FAILED [ 89%]would you like me to make an issue for this? |
working on some DRYness
not sure where I lost the correct import
looks like a copy and paste error (the removed names are valid for THREE WINDING AUTO TRANSFORMER SETTING and THREE WINDING TRANSFORMER SETTING (not TRANSFORMER SETTING)
was summing loads across phases this is the first steps in getting IEEE13 feeder results to match before implementing this the IEEE13 dss model would only segfault
- it appears that the openDSS set of voltage bases should be LL, not LN (deducting from IEEE openDSS examples). - the code was not handling the case of single phase regulators, which naturally have a LN `nominal_voltage`
hoping to fix so many seg faults by writing object settings in the correct order
also a bug fix in a logger.error
these are necessary for capcontrol in ditto (Capacitor.low/high were being used for opendss vmin/vmax, but the low and high values should be used for the capcontrol on/offsetting)
for cap control
order of terms were incorrect and was not parsing all values that are available (also using vmax/min without off/on settings)
was setting kV to LL values
add same test to opendss reader, which passes
might be some bugs to address, messy merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
working through a CYME v9 conversion to openDSS I have come across a few issues.
openDSS Writer:
kvarlimitis nowkvarmaxin openDSSCYME Reader:
LoadModelID(was adding up multipleLoadModelIDs when it should only use one)Other
check_transformer_phase_pathfor case of missing "wires" keyDiTToHasTraits(was trying to log objects)