Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: 新增所有端點可訪問的測試 #36

Merged
merged 6 commits into from
Dec 10, 2023
Merged

test: 新增所有端點可訪問的測試 #36

merged 6 commits into from
Dec 10, 2023

Conversation

iwtba4188
Copy link
Contributor

@iwtba4188 iwtba4188 commented Dec 7, 2023 •
edited
Loading

  • 現在無法解決有 test 無法通過的話，不會生成 coverage 資料，看有沒有更好的做法可以解決這個問題，或是說需要通過所有 test 之後算 coverage 才是正確的

@iwtba4188
fix(bus): 增加資料清理
acb01ee 
- 內部生成資料後，在選擇對應路線之前，先清理資料前後空白
@iwtba4188
fix(libraries): endpoint typo
f9b7fd3 
- libaray_name -> library_name
@iwtba4188
test: 新增所有端點可訪問的測試
0fc5312 
- 只測試各端點是否能夠正常回傳 `200: OK` 的 http 回應，不包含特殊測資測試
@iwtba4188
fix(utils): 新增 requests 的 timeout
1b57123 
- 避免 GitHub Action 的測試卡住
@iwtba4188
docs: config for testing and coverage-badge
466c6ca 
- 也暫時移除會導致測試失敗的部分
@iwtba4188 iwtba4188 requested a review from l7wei December 7, 2023 19:14
@iwtba4188 iwtba4188 marked this pull request as draft December 8, 2023 06:25
@iwtba4188 iwtba4188 closed this Dec 8, 2023
@iwtba4188 iwtba4188 reopened this Dec 8, 2023
@iwtba4188
feat(coverage): add smokeshow workflow
3e3642d 
- 將 coverage 的生成放到 smokeshow workflow
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iwtba4188 iwtba4188 marked this pull request as ready for review December 8, 2023 07:40
@iwtba4188 iwtba4188 added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 9, 2023
l7wei
l7wei approved these changes Dec 10, 2023
View reviewed changes
Copy link
Member

@l7wei l7wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起來沒什麼大問題，測試看看 workflow

@l7wei l7wei merged commit f97da5b into NTHU-SA:main Dec 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l7wei l7wei l7wei approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iwtba4188 @l7wei