Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add leading "//tests:" for given test targets #1079

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Do not add leading "//tests:" for given test targets #1079

merged 1 commit into from
Oct 3, 2024

Conversation

gpupuck
Copy link
Contributor

@gpupuck gpupuck commented Oct 2, 2024 •
edited
Loading

The original logic is if the given test targets do not start with //tests:, then add this prefix for them.

I'm removing this logic as:

  1. We don't actually see any use cases in the workflow
  2. It will block us running per-directory suite targets such as //tests/mosaic:gpu_tests

@gpupuck gpupuck self-assigned this Oct 2, 2024
andportnoy
andportnoy approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@andportnoy andportnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, explicit is better than implicit.

@gpupuck gpupuck merged commit 032e978 into main Oct 3, 2024
162 of 170 checks passed
@gpupuck gpupuck deleted the by/no-leading-/tests-addition branch October 3, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andportnoy andportnoy andportnoy approved these changes

@DwarKapex DwarKapex Awaiting requested review from DwarKapex

Assignees

@gpupuck gpupuck

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gpupuck @andportnoy