jax-toolbox-triage: improve documentation #1104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olupton
force-pushed
the
olupton/triage-docs
branch
from
953e5b5
to
0096bf0
Compare
olupton
force-pushed
the
olupton/triage-docs
branch
from
0096bf0
to
3545627
Compare
nouiz
reviewed
Oct 16, 2024
| specific commit of JAX or XLA. | ||
| __Note__: There is also a [triage tool](triage-tool.md), which can be used for | ||
| more granular bisection of failures in specific tests. Given a test expression that can | ||
| be run inside the nightl containers (*e.g.* `test-jax.sh jet_test_gpu`), it first |
There was a problem hiding this comment.
nightl -> nightly
Suggested change
| be run inside the nightl containers (*e.g.* `test-jax.sh jet_test_gpu`), it first | |
| be run inside the nightly containers (*e.g.* `test-jax.sh jet_test_gpu`), it first |
| __Note__: There is also a [triage tool](triage-tool.md), which can be used for | ||
| more granular bisection of failures in specific tests. Given a test expression that can | ||
| be run inside the nightl containers (*e.g.* `test-jax.sh jet_test_gpu`), it first | ||
| identifies the nightl container where the failure first appeared, and second attributes |
There was a problem hiding this comment.
Suggested change
| identifies the nightl container where the failure first appeared, and second attributes | |
| identifies the nightly container where the failure first appeared, and second attributes |
|
|
||
| `jax-toolbox-triage` is a tool to automate the process of attributing regressions to an | ||
| individual commit of JAX or XLA. | ||
| It takes as input a command that returns an error (non-zero) code when run in "recent" |
There was a problem hiding this comment.
Specify if the scripts are expected to be in the container already or not.
Maybe specify somewhere what will happens if JAX or XLA compilation fail? Does the script just skip that commit test with git bisect skip?
gpupuck
reviewed
Oct 18, 2024
| but that if JAX is moved forward to include | ||
| [jax@b164d](https://github.com/jax-ml/jax/commit/b164d67d4a9bd094426ff450fe1f1335d3071d03) | ||
| then the test fails. | ||
| This failure is fixed in XXX. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve documentation of the triage tool added in #793.