add timestamp support #11591
Merged
add timestamp support #11591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzelasko
reviewed
Dec 14, 2024
| if has_no_timestamp: | ||
| return super().text_to_ids(text_no_eos, lang_id) + [self.eos_id] | ||
| else: | ||
| word_text = time_pattern.sub("", text_no_eos).strip() |
There was a problem hiding this comment.
please refactor into a method def _text_with_timestamps_to_ids(...) and use return self._text_with_timestamps_to_ids(...) here
pzelasko
reviewed
Dec 14, 2024
| if time_index < len(time_ids) and result_ids[-1] != (time_ids[-1]): | ||
| result_ids.append(time_ids[-1]) | ||
| return result_ids + [self.eos_id] | ||
|
|
||
| return super().text_to_ids(text, lang_id) |
There was a problem hiding this comment.
you missed this branch (when lang_id isn't CANARY_SPECIAL_TOKENIZER and the text doesn't end in EOS) - it also needs to support tokenizing timestamps
There was a problem hiding this comment.
Thanks for catching that - fixed.
pzelasko
reviewed
Dec 14, 2024
|
PTAL @pzelasko |
pzelasko
previously approved these changes
Dec 18, 2024
kevinhu-nv
force-pushed
the
timestamp
branch
from
88b09e3 to
fe494ff
Compare
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu <[email protected]>
Signed-off-by: kevinhu-nv <[email protected]> Signed-off-by: kevinhu <[email protected]>
kevinhu-nv
force-pushed
the
timestamp
branch
from
fe494ff to
a64255c
Compare
Signed-off-by: kevinhu-nv <[email protected]>
|
@pzelasko Can you approve again? Rebased the repo for the tests. |
pzelasko
approved these changes
Dec 18, 2024
|
@titu1994 @stevehuang52 Could you take a look to trigger the workflow checks? |
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Mitigation guide:
By applying these rules, we reduce the occurance of this message in future. Thank you for improving NeMo's documentation! |
BoxiangW
pushed a commit
that referenced
this pull request
Dec 20, 2024
* add timestamp support Signed-off-by: kevinhu <[email protected]> * Add unit test, fix a branch, and refactor. Signed-off-by: kevinhu <[email protected]> * Apply isort and black reformatting Signed-off-by: kevinhu-nv <[email protected]> Signed-off-by: kevinhu <[email protected]> * Apply isort and black reformatting Signed-off-by: kevinhu-nv <[email protected]> --------- Signed-off-by: kevinhu <[email protected]> Signed-off-by: kevinhu-nv <[email protected]> Co-authored-by: kevinhu-nv <[email protected]>
BoxiangW
pushed a commit
that referenced
this pull request
Dec 23, 2024
* add timestamp support Signed-off-by: kevinhu <[email protected]> * Add unit test, fix a branch, and refactor. Signed-off-by: kevinhu <[email protected]> * Apply isort and black reformatting Signed-off-by: kevinhu-nv <[email protected]> Signed-off-by: kevinhu <[email protected]> * Apply isort and black reformatting Signed-off-by: kevinhu-nv <[email protected]> --------- Signed-off-by: kevinhu <[email protected]> Signed-off-by: kevinhu-nv <[email protected]> Co-authored-by: kevinhu-nv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add support for parsing timestamp data for training.
Collection: [Note which collection this PR will affect]
Changelog
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information