-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding serialization to all Auto* objects in HuggingFace transformers #11645
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: marcromeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
Signed-off-by: Marc Romeyn <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests for this? Something of the form
hf_autoclass = ...
_file = io.dump(hf_model)
loaded = io.load(file)
loaded == hf_autoclass
@@ -632,8 +632,10 @@ def _io_path_elements_fn(x): | |||
return x.__io__.__path_elements__() | |||
|
|||
|
|||
def _artifact_transform_save(cfg: fdl.Config, output_path: Path, relative_dir: Path = "."): | |||
for artifact in getattr(cfg.__fn_or_cls__, "__io_artifacts__", []): | |||
def _artifact_transform_save(instance, cfg: fdl.Config, output_path: Path, relative_dir: Path = "."): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Change default to Path(".")
Returns: | ||
The loaded HuggingFace model | ||
""" | ||
return auto_cls.from_pretrained(pretrained_model_name_or_path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcromeyn can we add trust_remote_code
option?
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information