Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to assign vocab and mergers file for mockdatamoddule #11678

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

BoxiangW
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@BoxiangW BoxiangW requested a review from yaoyu-33 December 20, 2024 01:51
BoxiangW and others added 2 commits December 20, 2024 01:52
@BoxiangW BoxiangW self-assigned this Dec 20, 2024
Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module pretraining
scripts/llm/pretraining.py:35:0: C0301: Line too long (151/119) (line-too-long)
scripts/llm/pretraining.py:144:0: C0301: Line too long (142/119) (line-too-long)
scripts/llm/pretraining.py:29:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/llm/pretraining.py:59:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/llm/pretraining.py:119:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/llm/pretraining.py:134:0: C0116: Missing function or method docstring (missing-function-docstring)
scripts/llm/pretraining.py:22:0: W0611: Unused Any imported from typing (unused-import)

-----------------------------------
Your code has been rated at 8.79/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.llm.gpt.data.mock
nemo/collections/llm/gpt/data/mock.py:33:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/llm/gpt/data/mock.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/mock.py:90:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/mock.py:95:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/llm/gpt/data/mock.py:100:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.37/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

@BoxiangW BoxiangW enabled auto-merge (squash) December 21, 2024 00:22
Copy link
Contributor

[🤖]: Hi @BoxiangW 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@BoxiangW BoxiangW merged commit 8aa4b60 into main Dec 23, 2024
184 of 191 checks passed
@BoxiangW BoxiangW deleted the boxiangw/mockdatavocabfix branch December 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants