-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require contiguous_iterator_tag
in C++17 as that is not satisfied by any standard container
#2613
base: main
Are you sure you want to change the base?
Conversation
🟨 CI finished in 1h 55m: Pass: 90%/366 | Total: 3d 21h | Avg: 15m 22s | Max: 1h 26m | Hits: 32%/19395
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda | |
CCCL C Parallel Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CCCL C Parallel Library |
🏃 Runner counts (total jobs: 366)
# | Runner |
---|---|
298 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
The concept seems to be too relaxed now, it fails some checks |
Oh yeah the check is that something with only the random_access_iterator_tag does not satisfy contiguous_iterator However, |
ca506a4
to
2cadd3c
Compare
🟨 CI finished in 1h 08m: Pass: 98%/366 | Total: 1d 20h | Avg: 7m 13s | Max: 49m 13s | Hits: 86%/22395
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda | |
CCCL C Parallel Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CCCL C Parallel Library |
🏃 Runner counts (total jobs: 366)
# | Runner |
---|---|
298 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
…sfied by any standard container
2cadd3c
to
2374de2
Compare
🟨 CI finished in 2h 18m: Pass: 98%/366 | Total: 3d 06h | Avg: 12m 53s | Max: 1h 26m | Hits: 35%/22395
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
CUDA Experimental | |
pycuda | |
CCCL C Parallel Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CCCL C Parallel Library |
🏃 Runner counts (total jobs: 366)
# | Runner |
---|---|
298 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
25 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
@@ -451,7 +451,6 @@ _LIBCUDACXX_CONCEPT_FRAGMENT( | |||
__contiguous_iterator_, | |||
requires(const _Ip& __i)( | |||
requires(random_access_iterator<_Ip>), | |||
requires(derived_from<_ITER_CONCEPT<_Ip>, contiguous_iterator_tag>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we scope this change to just c++17?
No description provided.