Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CUDAX] size_bytes in buffer types #2621

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[CUDAX] size_bytes in buffer types #2621

wants to merge 5 commits into from
+23 −2

Conversation

pciolkosz
Copy link
Contributor

size_bytes is a nice API in span, we should have it in the buffer types.

@pciolkosz pciolkosz requested a review from a team as a code owner October 24, 2024 20:50
@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 12m 39s: Pass: 100%/52 | Total: 2h 54m | Avg: 3m 21s | Max: 10m 55s | Hits: 86%/216

  • 🟩 cudax: Pass: 100%/52 | Total: 2h 54m | Avg: 3m 21s | Max: 10m 55s | Hits: 86%/216 

    🟩 cpu
  🟩 amd64              Pass: 100%/48  | Total:  2h 44m | Avg:  3m 25s | Max: 10m 55s | Hits:  86%/216   
  🟩 arm64              Pass: 100%/4   | Total: 10m 06s | Avg:  2m 31s | Max:  2m 58s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total:  1h 02m | Avg:  3m 15s | Max: 10m 52s | Hits:  86%/108   
  🟩 12.6               Pass: 100%/33  | Total:  1h 52m | Avg:  3m 23s | Max: 10m 55s | Hits:  86%/108   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total:  1h 02m | Avg:  3m 15s | Max: 10m 52s | Hits:  86%/108   
  🟩 nvcc12.6           Pass: 100%/33  | Total:  1h 52m | Avg:  3m 23s | Max: 10m 55s | Hits:  86%/108   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/52  | Total:  2h 54m | Avg:  3m 21s | Max: 10m 55s | Hits:  86%/216   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  6m 01s | Avg:  3m 00s | Max:  3m 07s
  🟩 Clang10            Pass: 100%/2   | Total:  5m 29s | Avg:  2m 44s | Max:  2m 47s
  🟩 Clang11            Pass: 100%/4   | Total: 10m 42s | Avg:  2m 40s | Max:  2m 57s
  🟩 Clang12            Pass: 100%/4   | Total: 11m 15s | Avg:  2m 48s | Max:  3m 03s
  🟩 Clang13            Pass: 100%/4   | Total: 11m 24s | Avg:  2m 51s | Max:  3m 02s
  🟩 Clang14            Pass: 100%/4   | Total: 12m 11s | Avg:  3m 02s | Max:  3m 52s
  🟩 Clang15            Pass: 100%/2   | Total:  7m 28s | Avg:  3m 44s | Max:  3m 46s
  🟩 Clang16            Pass: 100%/4   | Total: 12m 15s | Avg:  3m 03s | Max:  3m 27s
  🟩 Clang17            Pass: 100%/2   | Total:  7m 14s | Avg:  3m 37s | Max:  3m 47s
  🟩 Clang18            Pass: 100%/2   | Total:  8m 46s | Avg:  4m 23s | Max:  5m 20s
  🟩 GCC9               Pass: 100%/2   | Total:  5m 26s | Avg:  2m 43s | Max:  2m 45s
  🟩 GCC10              Pass: 100%/4   | Total: 10m 39s | Avg:  2m 39s | Max:  2m 46s
  🟩 GCC11              Pass: 100%/4   | Total: 12m 32s | Avg:  3m 08s | Max:  3m 46s
  🟩 GCC12              Pass: 100%/7   | Total: 23m 54s | Avg:  3m 24s | Max:  4m 38s
  🟩 GCC13              Pass: 100%/3   | Total:  7m 11s | Avg:  2m 23s | Max:  2m 32s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 10m 52s | Avg: 10m 52s | Max: 10m 52s | Hits:  86%/108   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 55s | Avg: 10m 55s | Max: 10m 55s | Hits:  86%/108   
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  1h 32m | Avg:  3m 05s | Max:  5m 20s
  🟩 GCC                Pass: 100%/20  | Total: 59m 42s | Avg:  2m 59s | Max:  4m 38s
  🟩 MSVC               Pass: 100%/2   | Total: 21m 47s | Avg: 10m 53s | Max: 10m 55s | Hits:  86%/216   
🟩 gpu
  🟩 v100               Pass: 100%/52  | Total:  2h 54m | Avg:  3m 21s | Max: 10m 55s | Hits:  86%/216   
🟩 jobs
  🟩 Build              Pass: 100%/47  | Total:  2h 32m | Avg:  3m 15s | Max: 10m 55s | Hits:  86%/216   
  🟩 Test               Pass: 100%/5   | Total: 21m 25s | Avg:  4m 17s | Max:  5m 20s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  2m 18s | Avg:  2m 18s | Max:  2m 18s
  🟩 90a                Pass: 100%/1   | Total:  2m 32s | Avg:  2m 32s | Max:  2m 32s
🟩 std
  🟩 17                 Pass: 100%/28  | Total:  1h 23m | Avg:  2m 58s | Max:  4m 38s
  🟩 20                 Pass: 100%/24  | Total:  1h 30m | Avg:  3m 47s | Max: 10m 55s | Hits:  86%/216

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

🏃‍ Runner counts (total jobs: 52)
# Runner
41 linux-amd64-cpu16
5 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

miscco
miscco reviewed Oct 24, 2024
View reviewed changes
cudax/include/cuda/experimental/__container/uninitialized_buffer.cuh
@@ -186,11 +186,17 @@ public:
}

//! @brief Returns the size of the buffer
_CCCL_NODISCARD _CCCL_HOST_DEVICE constexpr size_type size() const noexcept
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rather drop the _CCCL_HOST_DEVICE

conventionally the _CCCL_HOST_DEVICE macro commes before constexpr as all other attributes

@github-actions GitHub Actions
Copy link
Contributor

🟩 CI finished in 25m 39s: Pass: 100%/52 | Total: 4h 23m | Avg: 5m 03s | Max: 18m 55s | Hits: 84%/222

  • 🟩 cudax: Pass: 100%/52 | Total: 4h 23m | Avg: 5m 03s | Max: 18m 55s | Hits: 84%/222 

    🟩 cpu
  🟩 amd64              Pass: 100%/48  | Total:  4h 10m | Avg:  5m 12s | Max: 18m 55s | Hits:  84%/222   
  🟩 arm64              Pass: 100%/4   | Total: 12m 46s | Avg:  3m 11s | Max:  3m 44s
🟩 ctk
  🟩 12.0               Pass: 100%/19  | Total:  1h 39m | Avg:  5m 15s | Max: 18m 31s | Hits:  84%/111   
  🟩 12.6               Pass: 100%/33  | Total:  2h 43m | Avg:  4m 56s | Max: 18m 55s | Hits:  84%/111   
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/19  | Total:  1h 39m | Avg:  5m 15s | Max: 18m 31s | Hits:  84%/111   
  🟩 nvcc12.6           Pass: 100%/33  | Total:  2h 43m | Avg:  4m 56s | Max: 18m 55s | Hits:  84%/111   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/52  | Total:  4h 23m | Avg:  5m 03s | Max: 18m 55s | Hits:  84%/222   
🟩 cxx
  🟩 Clang9             Pass: 100%/2   | Total:  6m 58s | Avg:  3m 29s | Max:  3m 31s
  🟩 Clang10            Pass: 100%/2   | Total:  7m 26s | Avg:  3m 43s | Max:  3m 46s
  🟩 Clang11            Pass: 100%/4   | Total: 13m 39s | Avg:  3m 24s | Max:  3m 35s
  🟩 Clang12            Pass: 100%/4   | Total: 13m 40s | Avg:  3m 25s | Max:  3m 35s
  🟩 Clang13            Pass: 100%/4   | Total: 13m 50s | Avg:  3m 27s | Max:  3m 40s
  🟩 Clang14            Pass: 100%/4   | Total: 26m 25s | Avg:  6m 36s | Max: 16m 03s
  🟩 Clang15            Pass: 100%/2   | Total:  7m 03s | Avg:  3m 31s | Max:  3m 35s
  🟩 Clang16            Pass: 100%/4   | Total: 13m 47s | Avg:  3m 26s | Max:  3m 44s
  🟩 Clang17            Pass: 100%/2   | Total:  7m 13s | Avg:  3m 36s | Max:  3m 39s
  🟩 Clang18            Pass: 100%/2   | Total: 19m 07s | Avg:  9m 33s | Max: 15m 35s
  🟩 GCC9               Pass: 100%/2   | Total:  6m 40s | Avg:  3m 20s | Max:  3m 21s
  🟩 GCC10              Pass: 100%/4   | Total: 13m 33s | Avg:  3m 23s | Max:  3m 50s
  🟩 GCC11              Pass: 100%/4   | Total: 13m 16s | Avg:  3m 19s | Max:  3m 43s
  🟩 GCC12              Pass: 100%/7   | Total:  1h 09m | Avg:  9m 54s | Max: 18m 55s
  🟩 GCC13              Pass: 100%/3   | Total:  9m 05s | Avg:  3m 01s | Max:  3m 08s
  🟩 MSVC14.36          Pass: 100%/1   | Total: 11m 18s | Avg: 11m 18s | Max: 11m 18s | Hits:  84%/111   
  🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 43s | Avg: 10m 43s | Max: 10m 43s | Hits:  84%/111   
🟩 cxx_family
  🟩 Clang              Pass: 100%/30  | Total:  2h 09m | Avg:  4m 18s | Max: 16m 03s
  🟩 GCC                Pass: 100%/20  | Total:  1h 51m | Avg:  5m 35s | Max: 18m 55s
  🟩 MSVC               Pass: 100%/2   | Total: 22m 01s | Avg: 11m 00s | Max: 11m 18s | Hits:  84%/222   
🟩 gpu
  🟩 v100               Pass: 100%/52  | Total:  4h 23m | Avg:  5m 03s | Max: 18m 55s | Hits:  84%/222   
🟩 jobs
  🟩 Build              Pass: 100%/47  | Total:  2h 55m | Avg:  3m 44s | Max: 11m 18s | Hits:  84%/222   
  🟩 Test               Pass: 100%/5   | Total:  1h 27m | Avg: 17m 28s | Max: 18m 55s
🟩 sm
  🟩 90                 Pass: 100%/1   | Total:  3m 02s | Avg:  3m 02s | Max:  3m 02s
  🟩 90a                Pass: 100%/1   | Total:  3m 08s | Avg:  3m 08s | Max:  3m 08s
🟩 std
  🟩 17                 Pass: 100%/28  | Total:  2h 05m | Avg:  4m 28s | Max: 18m 55s
  🟩 20                 Pass: 100%/24  | Total:  2h 17m | Avg:  5m 44s | Max: 18m 16s | Hits:  84%/222

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
pycuda
CCCL C Parallel Library

🏃‍ Runner counts (total jobs: 52)
# Runner
41 linux-amd64-cpu16
5 linux-amd64-gpu-v100-latest-1
4 linux-arm64-cpu16
2 windows-amd64-cpu16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miscco miscco miscco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pciolkosz @miscco