AssetObject class to add or remove SceneObjects from Scene #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject in a scene through scene .xml file manipulation.
… Added the support of multi-shape assets.
move them, interaction with component objects and RT. Start material cells. Fix all .xml files from Sionna.
…s. Some fix are still necessary to pass all tests.
…ssetObject or a SceneObject is kept during scene reload. Reorganisation of all the asset related tests.
…ifying the radio_material of an asset or a scene object.
…cene class (using scene.get() or scene.objects), such that SceneObjects can be garbage collected when deleted from within the Scene class.
…Scene and RadioMaterial class documentations accordingly.
Signed-off-by: Guillaume Larue <[email protected]> Signed-off-by: Louis-Adrien Dufrène <[email protected]>
|
Hi @guillaume-larue, |
|
This will be very important funtionality! What about the merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to discussion 512
The present pull request enables the addition and removal of (group of) SceneObjects in the current scene. These objects, named assets, are handled by a dedicated new class,
AssetObject. They are described in the same way a scene is described, i.e., from a Blender Mitsuba Export .xml file and a set of .ply meshes. Hence, new asset objects can be created using Blender.The addition and removal of assets are straightforward.
AssetObjectbasically offers the same API properties asSceneObject, including position, orientation, velocity, and radio_materials. Assets can interact with ray tracing, as they are basically composed ofSceneObjects, hence relying on legacy features of Sionna.The pull request also proposes an improved way to manage the rendering of
RadioMaterial. Thanks to theBSDFclass, it is now possible to easily manipulate and update the way aRadioMaterialof the scene is rendered.A novel Jupyter Notebook named
Sionna_Ray_Tracing_Asset.ipynbis added to explain in detail how to use these features, and the documentation of the asset-related classes has been updated.New APIs for the added
AssetObjectsfunctionalities have been provided. No changes in legacy APIs, except forSceneObjectsreferenced outside theSceneclass, which are now weak-referenced to avoid remaining strong references to removedSceneObjects(when accessingscene.objectsproperty or callingscene.get("scene_object_name")).We have noticed the demands for signed-off commits only when preparing the Pull Request. Since the change in the git history would be quite significant, is this absolutely mandatory to do it on all the commits, or would a single signed-off commit be sufficient for the complete pull request (as provided here)?
Co-authored-by: [email protected]
Checklist
Co-authored-by: user@domainand ensure they signed off their commits too.