Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer versions #292

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Footer versions #292

merged 2 commits into from
Nov 29, 2023

Conversation

mnyrop
Copy link
Member

@mnyrop mnyrop commented Nov 29, 2023

Problem

Current staging footer shows "Running SDR 4.1.0", but it's actually running GBL 1.10.

Solution

Show GBL and SDR versions to make deploy tracking easier / current status more apparent.

Screenshot 2023-11-29 at 2 15 49 PM

PR Type

Feature

Notes

  • @the-codetrane we'll also want to mint a new/discrete tagged version for the prod deploy today, yeah? v2?
  • PR is slightly bigger than an ERB change to clean up some messiness:
    • looks like
      Dir["#{Rails.root}/lib/nyugeoblacklight/*.rb"].each {|file| require file }
      has been looking for lib/nyugeoblacklight all along but the dir in main is named lib/nyu_geoblacklight; the PR fixes the dir name to lib/geoblacklight
    • the actual version was in lib/nyu_geoblacklight.rb in main; PR moves it to lib/nyugeoblacklight/version.rb which is a more common pattern.
    • config/application.rb loads all of lib in main (including rake tasks and other junk). now it's scoped to config.eager_load_paths += Dir["#{Rails.root}/lib/nyugeoblacklight/*.rb"]

@mnyrop mnyrop added the look and feel enhancements look-feel or wording changes / improvements label Nov 29, 2023
@the-codetrane the-codetrane merged commit f337f68 into main Nov 29, 2023
1 check passed
@the-codetrane the-codetrane deleted the footer-versions branch November 29, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
look and feel enhancements look-feel or wording changes / improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants