Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Confirmed species #158

Closed
wants to merge 50 commits into from

Conversation

alexbelgium
Copy link

@alexbelgium alexbelgium commented Jul 25, 2024

The idea of this PR was that I wanted to verify which species are really there (= seen visually, or that I am 100% sure to be true) and which species are just probable. I've therefore implemented a simple text file to list confirmed species. If the species is not confirmed, there is a "?", if it is confirmed, there is a "checkmark".

Description : this feature proposal is to be able to visually show which species were verified to be confirmed, and which are not

How :

  • proposal is to create a new txt file named confirmed_species_list.txt that would contain the name of the confirmed species
  • when the Common Name is loaded in all page, it checks if it is part of this file. If yes, a little check icon appears next to it

Alternative considered :

  • Confirming observations at the level of the detection with a storage of the status in the sqlite - this would be too cumbersome and increase needlessly the sqlite size

It is possible to shift from one to the other by just clicking on the icon

image
image

@alexbelgium alexbelgium marked this pull request as ready for review July 25, 2024 07:57
@wenestvedt
Copy link

I like this idea!

Will there also be a way to mark species through the web interface?

@alexbelgium
Copy link
Author

I like this idea!

Will there also be a way to mark species through the web interface?

Yes! By clicking on the icon it alternates between confirmed (check) and to confirm (question mark)

@alexbelgium
Copy link
Author

I haven't added an update snippets as the file gets created on first access

@Emmo213
Copy link

Emmo213 commented Aug 7, 2024

While a neat idea if somebody didn't want to verify all their species there'd be a lot of question marks that wouldn't be helpful to them and would take up screen real estate. What about making it available as an on/off option through the settings?

@alexbelgium
Copy link
Author

Ok, I wanted to avoid cluttering options and code but I can add an on/off

It only shows on the "recordings" page so doesn't impact the other pages

@Emmo213
Copy link

Emmo213 commented Aug 7, 2024

It was just a suggestion. Maybe see what @Nachtzuster thinks? But you're right, being on the recordings page wouldn't be too intrusive.

@lloydbayley
Copy link

Wow! I've never seen a lint fail for over-indenting before! That's a new one for me!

@alexbelgium
Copy link
Author

Wow! I've never seen a lint fail for over-indenting before! That's a new one for me!

Strangest thing also is that I didn't touch it, it is the same initial code!

@lloydbayley
Copy link

Wow! I've never seen a lint fail for over-indenting before! That's a new one for me!

Strangest thing also is that I didn't touch it, it is the same initial code!

It must have noticed that you were poking around. Still, a bit rude attributing it to you! :)

@alexbelgium
Copy link
Author

Mmh not convinced with the specific detection level for confirmed species. I'll probably remove it

@alexbelgium
Copy link
Author

Closed, but I'll continue to update it as it is merged on the fly in my homeassistant add-on

@alexbelgium alexbelgium reopened this Sep 14, 2024
@alexbelgium
Copy link
Author

alexbelgium commented Sep 30, 2024

Added a feature to select only confirmed or unconfirmed species :

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants