-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test notification using same code base #174
Conversation
Feat 165 wiki link in notification
Update to emmo213 repo
Base64 encode the Apprise title and body when submitting the form
Notification enhancements
…3/BirdNET-Pi into notification_enhancements
Notification enhancements
Update Apprise version to 1.8.1
Update Apprise version to 1.8.1
It's been almost a month with no discussion. Should I close this PR as unwanted? |
I haven't had much time these last months, so anything that looks non-trivial and/or not-a-bug-fix gets pushed back. If you're still interested I can give some pointers on how to improve this PR |
@Nachtzuster yes please. It's been working really well for me, but I'm open to suggestions as long as the end result is the same. |
Rather that re-using Line 37 in 3d99530
Also, as mentioned before, no changes to unrelated files, please |
Your suggestion is to create a separate python file which invokes the existing notification logic? |
correct |
Moved the logic to its own file. |
Readme fix
Merge main to notification_enhancements to stay up to date
Interesting that you opted to wrap |
As mentioned in another pull request #167 the test notifications and regular notifications should use the same code base. These changes create a fake bird detection to allow the test notification to flow through the existing notification code. This will provide a better user experience because before it was confusing when a test notification worked but the actual notification didn't, or vice versa.