Add Purge Threshold #256
Open
Add Purge Threshold #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a purge threshold setting. This setting allows the user to control at what filled percentage the purge activities are run. This replaces the default, hard coded 95% point. The purge threshold defaults at the original 95%. I set a minimum of 20 and max of 99 because those values felt sensible but am open to changing those based on feedback. Note: The purge threshold is still active when the keep option is set. I added a note for this but this still presents some risk where users who change this while in Keep mode could have their services shut down earlier than they expect.
Adds a purge threshold setting. This setting allows the user to control at what filled percentage the purge activities are run. This replaces the default, hard coded 95% point. The purge threshold defaults at the original 95%. I set a minimum of 20 and max of 99 because those values felt sensible but am open to changing those based on feedback. Note: The purge threshold is still active when the keep option is set. I added a note for this but this still presents some risk where users who change this while in Keep mode could have their services shut down earlier than they expect. Patch: Fix a couple of typos in initial changes and improve formatting.
|
Hi, indeed looks useful for people who want to avoid being at limit of their disks ; or who share their system with data storage with another app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the threshold at which files are purged from disk is hard coded at 95%. Depending on users and systems this can be either too high or too low. Editing the threshold to adjust for user preferences would have to be done in the script where the disk cleanup is run. This is less than ideal because it puts this control out of scope for less technical users and would be wiped out or cause issues during updates.
Proposed Change
Add a purge threshold setting. This setting allows the user to control at what filled percentage the purge activities are run.
Detailed Description of Changes
Adds a configuration item to
advanced.phpto set the purge threshold. Also adds relevant description and warnings.Adds a snippet to
update_birdnet_snippets.shto set the default purge threshold. The default matches the threshold that was previously hardcoded.Changes the space equivalence check in
disk_check.shto use the newly defined purge threshold.Adds the purge threshold to
install_config.sh