Add PSP support #319
Open
Add PSP support #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkwouter
suggested changes
Aug 16, 2024
There was a problem hiding this comment.
I had some suggestions. It's really cool you got this running. We should take a look at why the you're getting crashes from the existing code. Some of these things may be related to us using gcc 14, which would mean easy fixes are available. Otherwise there might be some bugs in the PSPDEV sdk.
src/CMakeLists.txt
Outdated
| @@ -120,5 +121,31 @@ if(WIN32) | |||
| elseif(APPLE) | |||
| target_link_libraries(prince SDL2main SDL2 SDL2_image m) | |||
| else() # Linux, *BSD, etc. | |||
There was a problem hiding this comment.
I would keep this else and use elseif(PSP)
src/types.h
Outdated
Comment on lines
1352
to
1356
| #ifdef __PSP__ //for testing, PSP only reads input at 333mhz with 60 FPS | ||
| #define BASE_FPS 60 | ||
| #else | ||
| #define BASE_FPS 60 | ||
| #endif |
src/seg009.c
Outdated
| Uint64 timer_last_counter[NUM_TIMERS]; | ||
| #endif | ||
| int wait_time[NUM_TIMERS]; | ||
|
|
||
|
|
||
| #ifdef USE_COMPAT_TIMER | ||
| //#if defined(USE_COMPAT_TIMER) || defined(__PSP__) |
Use pkg_search and findpkgconfig Co-authored-by: Wouter Wijsman <[email protected]>
sharkwouter
reviewed
Aug 18, 2024
Co-authored-by: Wouter Wijsman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue with PSP was the crashes due to misaligned data. Now it works, but some issues were avoided in order for it to work (ini_process_word and such). Tested on real hardware (psp 2004 slim).
Note: Game still crashes whenever a short array[] op is done, due to the pragma(pop) and such (auto_moves,etc).