-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filter to curl request to prevent oom exceptions #45
base: master
Are you sure you want to change the base?
Conversation
|
I am not an elastic guy but i don't think it is misconfigured, just heavily used which leads to logging of a lot open http connections in the api output. It only happens sometimes a day. We see this huge data in all checks used by the getstatus() method with endpoint (/stats). |
Thanks for the info @c-kr
That is certainly strange. I will do some tests with my Elasticsearch instances and maybe I can reproduce this sometime. Nevertheless, I think your contribution makes sense and will be merged after tests. 👍 |
Self Installed Elasticsearch Version 7.17.1
Thanks |
disk check does not work anymore with that change. Before PR:
When applying the PR:
Maybe the filter needs to be adjusted. Can you check please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs some changes so that "disk" check works again.
Sometimes the apis response gets very long because it logs every http requests by default. On our test machine the following grep cmd filled up the 24gb memory within seconds:
if [[ -n $user ]] || [[ -n $(echo $esstatus | grep -i authentication) ]] ; then
We were able to mitigate it by adding a filter to the api requests to include only those values which are needed. This probably needs some more testing before merging, we only tested the memory mode