Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports to drop ovos-common-play dependency #26

Merged
merged 6 commits into from
Sep 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion __init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,16 @@
from urllib.parse import quote
from bs4 import BeautifulSoup
from neon_utils.file_utils import load_commented_file
from ovos_plugin_common_play import MediaType, PlaybackType
from ovos_workshop.skills.common_play import OVOSCommonPlaybackSkill, \
ocp_search
from ovos_utils import classproperty
from ovos_utils.log import LOG
from ovos_utils.process_utils import RuntimeRequirements
try:
from ovos_utils.ocp import MediaType, PlaybackType
except ImportError:
# TODO: Update import to ovos-utils when 0.1 is pinned as a minimum version
from ovos_workshop.decorators.ocp import MediaType, PlaybackType


class FreeMusicArchiveSkill(OVOSCommonPlaybackSkill):
Expand Down
1 change: 0 additions & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@ ovos-workshop~=0.0,>=0.0.7
beautifulsoup4~=4.11
# TODO: network patching dependency resolution
neon-utils[network]~=1.0,>=1.11.1a3
ovos-plugin-common-play~=0.0.3
ovos-utils~=0.0, >=0.0.28
1 change: 0 additions & 1 deletion skill.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"python": [
"beautifulsoup4~=4.11",
"neon-utils[network]~=1.0,>=1.11.1a3",
"ovos-plugin-common-play~=0.0.3",
"ovos-utils~=0.0, >=0.0.28",
"ovos-workshop~=0.0,>=0.0.7"
],
Expand Down
3 changes: 2 additions & 1 deletion test/test_skill.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@

import pytest

from ovos_plugin_common_play import MediaType
# TODO: Update import to ovos-utils when 0.1 is pinned as a minimum version
from ovos_workshop.decorators.ocp import MediaType
from neon_minerva.tests.skill_unit_test_base import SkillTestCase


Expand Down
Loading