Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement colors from the brand guidelines to "Side by side card" with solid color #323

Closed
DaphneKoren opened this issue Apr 13, 2023 · 9 comments · Fixed by #333
Closed
Assignees
Labels
enhancement New feature or request frontend UI and block related good first issue Good for newcomers

Comments

@DaphneKoren
Copy link
Collaborator

DaphneKoren commented Apr 13, 2023

More info can be found in #285

Expected results
https://www.figma.com/file/OeE1zEoK84ckQpsAVMP6Ps/Modifications-(Copy)?node-id=1039-13365&t=Ov0N3Sc0yBTopEfr-0

URLs
in https://www.netcentric.biz/
225551041-0260c311-74d3-4c0c-9ef8-2b645d1c0776

https://www.netcentric.biz/our-industries/automotive

@NCalexiaeche
Copy link
Collaborator

This should be a separated component from the image grey filter overlay.
Is it possible to copy that component & make change on this new one to fit this ticket need on the solid color?

@NCalexiaeche
Copy link
Collaborator

@sonaldhekale please provide guidelines for @alexnerdrumhansen to test it, can you create 2 test pages for that purpose with and without the block features to handle proper testing.

@sonaldhekale
Copy link
Collaborator

@alexnerdrumhansen
Copy link
Collaborator

Thanks @sonaldhekale !
As far as I can see the card on the left is not using the Midnight Blue colour from the Design proposal.
https://www.figma.com/file/OeE1zEoK84ckQpsAVMP6Ps/Modifications-(Copy)?type=design&node-id=1016-13324&t=PF4xMSbfCfDTXK0E-0
Do you have a link to the one with the Image @DaphneKoren mentioned by any chance?
Thanks!

@nc-andreashaller
Copy link
Collaborator

@sonaldhekale please clean up the PR as discussed so the tests happen with the "final" code version.

@sonaldhekale
Copy link
Collaborator

@nc-andreashaller
Copy link
Collaborator

We can merge the PR as soon as Alex gives the QA "go".

@alexnerdrumhansen
Copy link
Collaborator

The Teal colour should still be replaced by the Midnight Blue as seen here: https://www.figma.com/file/OeE1zEoK84ckQpsAVMP6Ps/Modifications-(Copy)?type=design&node-id=1060-13437&t=e5Pt6puL43AZNAUw-0 (Frame 17).

@DaphneKoren
Copy link
Collaborator Author

Screenshot 2023-05-25 at 11 33 19
Solid colour issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend UI and block related good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants