Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

323 Applying solid colors to the cards #333

Merged
merged 11 commits into from
May 26, 2023
Merged

323 Applying solid colors to the cards #333

merged 11 commits into from
May 26, 2023

Conversation

sonaldhekale
Copy link
Collaborator

@sonaldhekale sonaldhekale commented May 17, 2023 •
edited
Loading

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@sonaldhekale sonaldhekale linked an issue May 17, 2023 that may be closed by this pull request
Implement colors from the brand guidelines to "Side by side card" with solid color #323
Closed
@aem-code-sync
Copy link

aem-code-sync bot commented May 17, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented May 17, 2023

Page Score PSI Audit Google
/ SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented May 19, 2023

Page Score PSI Audit Google
/drafts/sdhekale/cards-solidcolors SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented May 22, 2023

Page Score PSI Audit Google
/drafts/sdhekale/cards-solidcolors SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented May 23, 2023

Page Score PSI Audit Google
/drafts/sdhekale/cards-solidcolors SI FCP LCP TBT CLS PSI

1 similar comment
@aem-code-sync
Copy link

aem-code-sync bot commented May 23, 2023

Page Score PSI Audit Google
/drafts/sdhekale/cards-solidcolors SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented May 24, 2023

Page Score PSI Audit Google
/drafts/sdhekale/cards-solidcolors SI FCP LCP TBT CLS PSI

@sonaldhekale
Copy link
Collaborator Author

Hello @alexnerdrumhansen i cleaned the PR so you can test it on https://323-implement-solid-colors--cn-website--netcentric.hlx.page/drafts/sdhekale/cards-solidcolors

@alexnerdrumhansen
Copy link
Collaborator

The Teal colour on the left should be Midnight Blue as seen here:
https://www.figma.com/file/OeE1zEoK84ckQpsAVMP6Ps/Modifications-(Copy)?type=design&node-id=1060-13437&t=e5Pt6puL43AZNAUw-0

@alexnerdrumhansen
Copy link
Collaborator

Screenshot 2023-05-25 at 08 28 41 Screenshot 2023-05-25 at 08 30 32

@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

Page Scores Audits Google
/drafts/sdhekale/cards-solidcolors PERFORMANCE A11Y SEO BEST PRACTICES SI FCP FMP LCP TTI TBT CLS PSI

@DaphneKoren
Copy link
Collaborator

issue is fixed both block options colour and images look good
Screenshot 2023-05-25 at 11 43 03

nc-andreashaller
nc-andreashaller reviewed May 25, 2023
View reviewed changes
blocks/cards/cards.css Outdated
@@ -421,3 +430,56 @@
background-color: var(--bg-text-light-plum);
color: var(--c-dark-plum);
}

:root {
--c-midnight-blue: #000048;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I can see we have this already defined: https://github.com/Netcentric/cn-website/blob/main/styles/styles.css#L43

@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

Page Scores Audits Google
/drafts/sdhekale/cards-solidcolors Lighthouse returned error: Something went wrong. PSI

@aem-code-sync
Copy link

aem-code-sync bot commented May 25, 2023

Page Scores Audits Google
/drafts/sdhekale/cards-solidcolors PERFORMANCE A11Y SEO BEST PRACTICES SI FCP FMP LCP TTI TBT CLS PSI

@nc-andreashaller nc-andreashaller merged commit eca99e5 into main May 26, 2023
@nc-andreashaller nc-andreashaller deleted the 323-implement-solid-colors branch May 26, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nc-andreashaller nc-andreashaller nc-andreashaller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement colors from the brand guidelines to "Side by side card" with solid color
4 participants
@sonaldhekale @alexnerdrumhansen @DaphneKoren @nc-andreashaller