Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

329 multicolour accordion #344

Merged
merged 15 commits into from
Aug 10, 2023
Merged

329 multicolour accordion #344

merged 15 commits into from
Aug 10, 2023

Conversation

sonaldhekale
Copy link
Collaborator

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@sonaldhekale sonaldhekale linked an issue Jun 13, 2023 that may be closed by this pull request
Block 6 - Multicolour Accordion #329
Closed
@aem-code-sync
Copy link

aem-code-sync bot commented Jun 13, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 13, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

nc-andreashaller
nc-andreashaller requested changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@nc-andreashaller nc-andreashaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@sonaldhekale
Copy link
Collaborator Author

hi changes requested are done have a look @nc-andreashaller.Thanks

nc-andreashaller
nc-andreashaller previously requested changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@nc-andreashaller nc-andreashaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed via Slack please review this PR together in a pair programming style with an experienced developer and let me know once it is ready to be reviewed.

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 23, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 27, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 28, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 28, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 29, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jun 30, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 3, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Jul 17, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 1, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 3, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@alexnerdrumhansen
Copy link
Collaborator

A couple of concerns.

  1. We need to make a more mobile friendly version when viewed on smaller viewports. @Gonzalo-CG Can you have a look at this please? Currently only a short text displays on mobile and we'd want a good experience for those visiting from mobile too.
  2. I tried to add a link in one of the drawers to verify that works, but once I edited the accordion no longer shows properly on the page. Is there a trick to getting it display as an accordion after editing @sonaldhekale ?

Thanks!

Attaching mobile view
Screenshot 2023-08-08 at 09 23 09

@Gonzalo-CG
Copy link
Collaborator

@sonaldhekale @alexnerdrumhansen as for the mobile view, Joel recommended reducing the font size & eliminating the padding on the left side.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 9, 2023

Page Scores Audits Google
/drafts/sdhekale/multicolor-accordian PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@alexnerdrumhansen
Copy link
Collaborator

Changes made make it look much better on mobile.
Can now also verify that links will open in new tabs.

Thanks @sonaldhekale !
Screenshot 2023-08-09 at 15 03 22

@sonaldhekale sonaldhekale merged commit b3ebaa3 into main Aug 10, 2023
2 checks passed
@sonaldhekale sonaldhekale deleted the 329-multicolour-accordion branch August 10, 2023 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihai-buricea-net mihai-buricea-net mihai-buricea-net approved these changes

@nc-andreashaller nc-andreashaller nc-andreashaller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block 6 - Multicolour Accordion
5 participants
@sonaldhekale @alexnerdrumhansen @Gonzalo-CG @nc-andreashaller @mihai-buricea-net