Instrument website with AEM Experimentation plugin #405
Conversation
git-subtree-dir: plugins/experimentation git-subtree-split: 162896dd4908cf5b5270477a9a367ccd649d4d7d
02617d2 fix: sanitize experiment and variant names for proper css class injection d6318cf fix: gracefully handle projects where block-level experiments aren't instrumented git-subtree-dir: plugins/experimentation git-subtree-split: 02617d2381ad206f5186cede9255dc60b572755f
4ff6246 fix: leaking heading styles into the pill git-subtree-dir: plugins/experimentation git-subtree-split: 4ff6246cf3730bea48c189dfcac00c2953feb409
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
@raji-unni To address the linting issues, we can add |
ramboz
changed the title
There was a problem hiding this comment.
is this file needed if we have the ignore in the root file already?
There was a problem hiding this comment.
the way the plugins work is that they essentially cache all the files from the source repo: https://github.com/adobe/aem-experimentation
it's essentially creating a subtree or submodule it git. in theory you could remove some of the files, but it's easier to keep them as-is so fetching updates is easier and doesn't cause conflicts
|
@nc-andreashaller Do you want us to go ahead and merge this or are you taking over and merging when you are ready to move forward? |
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: