Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vat logo added and 404 page markup set to match VAT messaging #1

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Vat logo added and 404 page markup set to match VAT messaging #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e116d8
Logo added and 404 page now has VAT messaging and markup
dragandimic Jun 7, 2024
88f2738
VAT-1: exception added for logotypes. they should not be transformed …
dragandimic Jun 7, 2024
7e5700b
VAT-1: centering the 404 error message
dragandimic Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions 404.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,21 @@
<header></header>
<main class="error">
<div class="section">
<svg viewBox="1 0 38 18" class="error-number">
<text x="0" y="17">404</text>
</svg>
<h2 class="error-message">Page Not Found</h2>
<p class="button-container">
<a href="/" class="button secondary error-button-home">Go home</a>
</p>
<div class="container-fluid">
<div class="row">
<div class="col-12 col-md-8"><h1> 404 Page Not Found </h1>
<h3> Sorry, this page is not available — try searching again or navigate back to the homepage. </h3></div>
</div>
<div class="row">
<div class="col-12">
<div class="horizontal-divider mt-5 mt-md-10 mb-5 mb-md-10"></div>
</div>
</div>
<div class="row">
<div class="col-12"><a href="https://www.vatvalve.com" class="btn --primary --back --inline"> Go back </a>
</div>
</div>
</div>
</div>
</main>
<footer></footer>
Expand Down
14 changes: 14 additions & 0 deletions icons/vat-logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion scripts/aem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,8 +424,9 @@ function decorateButtons(element) {
if (a.href !== a.textContent) {
const up = a.parentElement;
const twoup = a.parentElement.parentElement;
const parentIsLogo = a.closest('logo.block');
if (!a.querySelector('img')) {
if (up.childNodes.length === 1 && (up.tagName === 'P' || up.tagName === 'DIV')) {
if (up.childNodes.length === 1 && (up.tagName === 'P' || up.tagName === 'DIV') && !parentIsLogo) {
a.className = 'button'; // default
up.classList.add('button-container');
}
Expand Down
5 changes: 5 additions & 0 deletions styles/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,3 +224,8 @@ main .section.light,
main .section.highlight {
background-color: var(--light-color);
}

.error .container-fluid-container {
margin-left: auto;
margin-right: auto;
}