Truck features #43 #155
Truck features #43 #155
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
|
TomaszDziezykNetcentric
requested review from
Lakshmishri,
cogniSyb and
markovukiceviccn
|
I expect the main browser scrollbar to be present, and that as a user I can also use the keyboard (arrows/spacebar/page up/page down). Example of this can be found on https://www.elgato.com/eu/en/p/prompter: |
|
|
Updated |
|
|
I made the changes. Now we can change the number of pixels needed to change the slide in one variable (SLIDE_SCROLL_PADDING_IN_PX). |
@TomaszDziezykNetcentric In mobile view there a is huge space after the bottom text. As per my understanding of the requirements and design the bottom text should stick to the bottom of the mobile screen and the images should be in the middle of the heading and the text |
|
@TomaszDziezykNetcentric also the blur effect is missing for mobile. Not sure if that was part of requirement or not |
|
|
|
Good point, @taimurCognizant. This is a bit difficult to get out of Figma. We might want to use |
I agree that the blur effect should be there. |
|
@cogniSyb @taimurCognizant |
|
|
|
|
|
||
| let slideIndex = 0; | ||
|
|
||
| window.addEventListener('scroll', debounce(() => { |
There was a problem hiding this comment.
@TomaszDziezykNetcentric The snapping function doesn't work properly. Because of debounce the values inside the function are not precise. I suggest removing debouncing.
There was a problem hiding this comment.
debouce removed
|
Fix #43
Test URLs: