Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion column block #114 #203

Merged
merged 16 commits into from
Feb 15, 2024
Merged

Accordion column block #114 #203

merged 16 commits into from
Feb 15, 2024

Conversation

jonatan-lledo-netcentric
Copy link
Collaborator

@jonatan-lledo-netcentric jonatan-lledo-netcentric commented Jan 19, 2024

Variants

The left variant can be detected by positioning the images in the right side or by adding the variant keyword Left.
For the Gray Background variant, can be added as a section metadata as style option OR as a regular variant.

the red mark over the title is added always by the block

Test URL

drafts/jlledo/v2/accordion-column-demo

Fix #114

Test URLs:

Copy link
Contributor

aem-code-sync bot commented Jan 19, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link
Contributor

aem-code-sync bot commented Jan 19, 2024

Page Scores Audits Google
/drafts/jlledo/v2/accordion-column-demo PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@cogniSyb cogniSyb changed the title v1 accordion-column block with left variant Accordion column block #114 Jan 19, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block January 19, 2024 14:30 Inactive
Copy link
Collaborator

@cogniSyb cogniSyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen in the Sidekick Library, we can combine blocks. I’ve expected v2-accordion to be used here, with some adjustments. Is that feasible or not?

Functionality-wise you can only open one item in the accordion. But we can close all of them, leaving a gap where the image was. Could we make sure that there’s always one item open in the accordion?

blocks/v2-accordion-column/v2-accordion-column.js Outdated Show resolved Hide resolved
blocks/v2-accordion-column/v2-accordion-column.js Outdated Show resolved Hide resolved
blocks/v2-accordion-column/v2-accordion-column.css Outdated Show resolved Hide resolved
@SantiagoHomps-NC
Copy link
Contributor

I see some space left of the image that makes the VW a little bit wider than it should... dont know where this is coming
Screenshot 2024-01-22 at 12 51 49

@SantiagoHomps-NC
Copy link
Contributor

Also check margins/paddings for desktop in v2-accordion-column__item-header-button

@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block January 22, 2024 15:36 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block January 23, 2024 17:58 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block January 24, 2024 09:50 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block January 24, 2024 13:40 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block January 24, 2024 13:47 Inactive
@cogniSyb cogniSyb added the FR Functional requirement label Jan 24, 2024
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block January 26, 2024 13:50 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block February 8, 2024 08:15 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block February 8, 2024 14:28 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block February 14, 2024 11:21 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 114-accordion-column-block February 14, 2024 11:31 Inactive
@cogniSyb cogniSyb merged commit 7fad9e9 into develop Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR Functional requirement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants