-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion column block #114 #203
Conversation
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As seen in the Sidekick Library, we can combine blocks. I’ve expected v2-accordion to be used here, with some adjustments. Is that feasible or not?
Functionality-wise you can only open one item in the accordion. But we can close all of them, leaving a gap where the image was. Could we make sure that there’s always one item open in the accordion?
Also check margins/paddings for desktop in |
Variants
The left variant can be detected by positioning the images in the right side or by adding the variant keyword
Left
.For the
Gray Background
variant, can be added as a section metadata as style optionOR as a regular variant.the red mark over the title is added always by the block
Test URL
drafts/jlledo/v2/accordion-column-demo
Fix #114
Test URLs: