Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10 v2 truck builder #50

Closed
wants to merge 3 commits into from
Closed

Conversation

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 21, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@TomaszDziezykNetcentric TomaszDziezykNetcentric marked this pull request as ready for review August 21, 2023 10:41
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 21, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/truck-builder PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@kesiah kesiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I thought this component should be completely static, image + text.

@@ -203,7 +203,7 @@
}

html {
font-size: 10px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, don't change this in Mack, if we do so, it should be done wrapped by redesign-v2 ;)

@cogniSyb
Copy link
Collaborator

This is actually creating #9. Let’s discuss in our next meeting :)

@Lakshmishri
Copy link
Collaborator

This will be handled as part of new v2-column-block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage: Mack Truck Builder Form/CTA (MVP-static) Block
6 participants