Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37 scroll to top button #57

Merged
merged 9 commits into from
Aug 28, 2023
Merged

37 scroll to top button #57

merged 9 commits into from
Aug 28, 2023

Conversation

avinashNChavan
Copy link
Collaborator

@avinashNChavan avinashNChavan commented Aug 24, 2023

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 24, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 24, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@kesiah kesiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine the icon should be centred in the box, and now it is not.
image

blocks/v2-footer/v2-footer.js Outdated Show resolved Hide resolved
blocks/v2-footer/v2-footer.js Outdated Show resolved Hide resolved
blocks/v2-footer/v2-footer.js Outdated Show resolved Hide resolved
blocks/v2-footer/v2-footer.css Outdated Show resolved Hide resolved
blocks/v2-footer/v2-footer.css Show resolved Hide resolved
blocks/v2-footer/v2-footer.css Outdated Show resolved Hide resolved
blocks/v2-footer/v2-footer.js Outdated Show resolved Hide resolved
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

blocks/v2-footer/v2-footer.css Outdated Show resolved Hide resolved
blocks/v2-footer/v2-footer.js Outdated Show resolved Hide resolved
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

blocks/v2-footer/v2-footer.css Outdated Show resolved Hide resolved
blocks/v2-footer/v2-footer.css Outdated Show resolved Hide resolved
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 25, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

blocks/v2-footer/v2-footer.js Show resolved Hide resolved
blocks/v2-footer/v2-footer.css Outdated Show resolved Hide resolved
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Aug 28, 2023

Page Scores Audits Google
/drafts/tdziezyk/v2/hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@Lakshmishri Lakshmishri merged commit cf2931a into footer-new Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants