update fill & stroke functionallity in svgs #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesiah
requested review from
Lakshmishri,
SantiagoHomps-NC,
TomaszDziezykNetcentric,
cogniSyb and
avinashNChavan
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
This comment was marked as outdated.
This comment was marked as outdated.
Lakshmishri
requested changes
Aug 30, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
done! |
Lakshmishri
approved these changes
Aug 30, 2023
TomaszDziezykNetcentric
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of applying a class for accent colors and having general styling in the styles, which are difficult to change from a block.
Now, all the icons should be using the CSS variables
var(--color-icon, #000)orvar(--color-icon-accent, #B3976B)in fill or stroke properties. This way we are able to change the color of the icon, just changing the CSS variable.Test URLs: