-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
35 specifications #80
Conversation
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the accordion buttons being keyboard focusable. However, on desktop, I can interact with the nested accordion buttons. So I can open/close the item, then some margin appears. Can you remove the possibility to focus?
gap: 40px 16px; | ||
} | ||
|
||
.v2-specifications__list--with-text:has(> :nth-child(5)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should document somewhere that this is currently not supported in Firefox; being a known bug we won’t fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: https://bugzilla.mozilla.org/show_bug.cgi?id=1853701
has been included in Firefox :firefox: 119 Nightly
|
|
Fix #35
Test URLs: