Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

35 specifications #80

Merged
merged 5 commits into from
Sep 22, 2023
Merged

35 specifications #80

merged 5 commits into from
Sep 22, 2023

Conversation

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Sep 19, 2023

Page Scores Audits Google
/drafts/laura/specs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Collaborator

@cogniSyb cogniSyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the accordion buttons being keyboard focusable. However, on desktop, I can interact with the nested accordion buttons. So I can open/close the item, then some margin appears. Can you remove the possibility to focus?

blocks/v2-accordion/v2-accordion.css Outdated Show resolved Hide resolved
blocks/v2-accordion/v2-accordion.css Outdated Show resolved Hide resolved
blocks/v2-specifications/v2-specifications.css Outdated Show resolved Hide resolved
blocks/v2-specifications/v2-specifications.css Outdated Show resolved Hide resolved
blocks/v2-specifications/v2-specifications.css Outdated Show resolved Hide resolved
blocks/v2-accordion/v2-accordion.css Outdated Show resolved Hide resolved
gap: 40px 16px;
}

.v2-specifications__list--with-text:has(> :nth-child(5)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document somewhere that this is currently not supported in Firefox; being a known bug we won’t fix

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: https://bugzilla.mozilla.org/show_bug.cgi?id=1853701
has been included in Firefox :firefox: 119 Nightly

blocks/v2-specifications/v2-specifications.css Outdated Show resolved Hide resolved
blocks/v2-accordion/v2-accordion.css Outdated Show resolved Hide resolved
@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Sep 20, 2023

Page Scores Audits Google
/drafts/laura/specs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link
Contributor

aem-code-sync bot commented Sep 22, 2023

Page Scores Audits Google
/drafts/laura/specs PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kesiah kesiah merged commit 078a888 into develop Sep 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants