13 trucks carousel #82
Conversation
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
|
|
…into 13-trucks-carousel
|
|
kesiah
requested review from
Lakshmishri,
TomaszDziezykNetcentric,
cogniSyb and
markovukiceviccn
|
| } | ||
|
|
||
| /* stylelint-disable-next-line no-descending-specificity */ | ||
| .v2-truck-lineup__navigation-item button { |
There was a problem hiding this comment.
Could you reset the font-weight here to get rid of faux bold?
There was a problem hiding this comment.
Instead of changing this button, I updated in styles, because by default button is using font-family Helvetica Roman, so the weight there was already wrong.
|
|
||
| .v2-truck-lineup__navigation-item.active button, | ||
| .v2-truck-lineup__navigation-item button:hover { | ||
| --color-icon: var(--c-primary-black); |
There was a problem hiding this comment.
The icon should be getting the Accent/Copper colour here
There was a problem hiding this comment.
Just the icon is using accent copper color, can you confirm? And check if the behaviour is how you expect?
|
|
…into 13-trucks-carousel
|
|
|
The aspect-ratio: 16:9 is distorting the images 
|
|
Are we missing block title in this component?
|
Correct. We've communicated the new image requirements to the client. Contents need to be updated in the CMS |
|
Usually the titles are done in another component, can you confirm @cogniSyb @Lakshmishri that in Mack we follow the same? |
We should definitely pick this up and put it in a separate block :) |
Fix #13
Test URLs: