fix inpage navigation #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesiah
requested review from
Lakshmishri,
TomaszDziezykNetcentric,
cogniSyb and
markovukiceviccn
|
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
|
Could you fix the faux bold here? |
Currently selected item is not visible in a drop down list. Is this intentional, since it is different behaviour compared to Volvo trucks where the currently selected item is visible in the drop down list? |
|
done |
You are right, it's done on purpose. This is what I understood from the designs, that the selected item should no be shown in the list. |
cogniSyb
approved these changes
Sep 22, 2023
|
TomaszDziezykNetcentric
approved these changes
Sep 25, 2023
Lakshmishri
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #26
Test URLs: