Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media with Text Block #180 #282

Merged
merged 47 commits into from
Jan 5, 2024
Merged

Media with Text Block #180 #282

merged 47 commits into from
Jan 5, 2024

Conversation

markovukiceviccn
Copy link
Collaborator

@markovukiceviccn markovukiceviccn commented Dec 8, 2023 •
edited
Loading

@markovukiceviccn markovukiceviccn self-assigned this Dec 8, 2023
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 8, 2023 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 8, 2023 •
edited
Loading

Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

cogniSyb
cogniSyb requested changes Dec 12, 2023
View reviewed changes
blocks/v2-media-with-text/v2-media-with-text.js Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.js Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.js Outdated Show resolved Hide resolved
@markovukiceviccn markovukiceviccn removed the request for review from taimurCognizant December 14, 2023 11:15
TomaszDziezykNetcentric
TomaszDziezykNetcentric suggested changes Dec 15, 2023
View reviewed changes
blocks/v2-media-with-text/v2-media-with-text.css Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.js Show resolved Hide resolved
styles/styles.css Outdated Show resolved Hide resolved
@aem-code-sync AEM Code Sync
Copy link
Contributor

aem-code-sync bot commented Dec 15, 2023 •
edited
Loading

Page Scores Audits Google
/drafts/taimur/v2-media-with-text PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

cogniSyb
cogniSyb requested changes Dec 15, 2023
View reviewed changes
blocks/v2-media-with-text/v2-media-with-text.css Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.css Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.css Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.css Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.css Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.css Outdated Show resolved Hide resolved
blocks/v2-media-with-text/v2-media-with-text.css Show resolved Hide resolved
@taimurCognizant taimurCognizant mentioned this pull request Dec 20, 2023
Closed
@aem-code-sync aem-code-sync bot temporarily deployed to 180-media-with-text January 3, 2024 10:18 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 180-media-with-text January 3, 2024 17:35 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 180-media-with-text January 5, 2024 09:58 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 180-media-with-text January 5, 2024 11:17 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 180-media-with-text January 5, 2024 11:54 Inactive
@aem-code-sync aem-code-sync bot temporarily deployed to 180-media-with-text January 5, 2024 12:19 Inactive
@Lakshmishri Lakshmishri merged commit 1d0a596 into develop Jan 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taimurCognizant taimurCognizant taimurCognizant left review comments

@cogniSyb cogniSyb cogniSyb approved these changes

@TomaszDziezykNetcentric TomaszDziezykNetcentric TomaszDziezykNetcentric approved these changes

@Lakshmishri Lakshmishri Lakshmishri approved these changes

@SantiagoHomps-NC SantiagoHomps-NC Awaiting requested review from SantiagoHomps-NC

Assignees

@taimurCognizant taimurCognizant

Labels
FR Functional requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@markovukiceviccn @Lakshmishri @TomaszDziezykNetcentric @cogniSyb @taimurCognizant @santi-homps