Improve Stack Trace tracking for Instrumentation #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgallardo-netflix
requested changes
Feb 6, 2024
archaius-core/src/main/java/com/netflix/config/ConcurrentCompositeConfiguration.java
Outdated
Show resolved
Hide resolved
archaius-core/src/main/java/com/netflix/config/ConcurrentCompositeConfiguration.java
Show resolved
Hide resolved
archaius-core/src/main/java/com/netflix/config/ConcurrentCompositeConfiguration.java
Show resolved
Hide resolved
rgallardo-netflix
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add archaius_stack_trace_enabled_properties which allows tracking of individual properties (instead of all of them) so we can reduce runtime impact of calculating stack traces. We can use this to only track some unused global fast properties.
This new set will also maintain all the properties associated with specific call sites, in case we are calling several.
Also surfaces these Maps as they were only accessible via the debugger before