Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw ParseException when a configuration setting can't be parsed as the type requested #735

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Throw ParseException when a configuration setting can't be parsed as the type requested #735

merged 1 commit into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. Throw ParseException when a configuration setting can't be parsed as … 

    …the type requested.

Homogenize the handling of parsing errors. Before this change, some code paths in the default Property implementation would silently swallow parsing errors and either return a defaultValue or null (even for non-nullable methods!) This leads to errors that are hard to debug.

Throwing a ParseException is a behaviour change that will lead to simpler debugging, at the expense of surfacing latent bugs in user code. For example, if bad values were being set in config files, the code will now fail instead of silently returning a different value than expected.
    @rgallardo-netflix
    rgallardo-netflix committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    add6cf1 View commit details
    Browse the repository at this point in the history