Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go back to the old behavior of returning null on ParseExceptions #738

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Go back to the old behavior of returning null on ParseExceptions #738

merged 1 commit into from
Oct 4, 2024

Commits on Oct 4, 2024

  1. Go back to the old behavior of returning null on ParseExceptions 

    We discovered that too many consumers depend on the old behavior that avoided throwing exceptions from configuration reading calls. Trying to adapt code paths that put these calls in the middle of critical request-servicing code is too onerous.

This version DOES fix the old bug that caused properties with defaults (from the Property.orElse() method) to fail for this "invalid setting" case. They will now return the default value.

We are also retaining the noisy logging of parsing errors, to assist users with detection and fixing.
    @rgallardo-netflix
    rgallardo-netflix committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b0eb502 View commit details
    Browse the repository at this point in the history