Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logic for plot limits #48

Merged
merged 6 commits into from
Jul 18, 2024
Merged

Conversation

cosimolupo
Copy link
Contributor

Changed the logic on plot limits (in config files, 'None' is now accepted as value for t_start/t_stop to plot the entire signal).

@mdenker
Copy link
Member

mdenker commented Feb 22, 2024

@cosimolupo Possibly already implemented. Please check and close if duplicate.

@mdenker
Copy link
Member

mdenker commented Feb 22, 2024

Possibly new PR for the change in pipeline/utils/parse.py ?

@cosimolupo
Copy link
Contributor Author

Dear @mdenker, also in this case I re-aligned the branch to the current HEAD of NeuralEnsemble/cobrawap, and then added back the only changes still needed, after the introduction of the robust_t function in neo_utils.py, which takes care of checking None values and values which are out of the original signal [t_start,t_stop] range.

@cosimolupo cosimolupo self-assigned this Mar 20, 2024
Copy link
Member

@mdenker mdenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can judge, this seems fine to me.

Comment on lines 22 to 23
PLOT_TSTART: 0 # float (in s) or 'None' -> T_START of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> T_STOP of the input signal is used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in the following, does T_START refer to t_start of the Neo object? In that case I would suggest

Suggested change
PLOT_TSTART: 0 # float (in s) or 'None' -> T_START of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> T_STOP of the input signal is used
PLOT_TSTART: 0 # float (in s) or 'None' -> t_start of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> t_stop of the input signal is used

Copy link
Contributor Author

@cosimolupo cosimolupo Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they refer to the attributes of the neo object. I used the uppercase notation as in the config files they are introduced this way. Anyway, let's decide if switch to the lowercase version, and then I will fix them coherently.

@cosimolupo cosimolupo added this to the v0.2.0 milestone Mar 21, 2024
@cosimolupo
Copy link
Contributor Author

@mdenker I adapted the description in config template files, so to make more explicit and clear what means setting PLOT_TSTART and/or PLOT_TSTOP value to 'None'.

@cosimolupo
Copy link
Contributor Author

Merging Pull Request #61 added some extra spacings, which I fixed in a further commit.

@mdenker
Copy link
Member

mdenker commented May 22, 2024

Merge as soon as version number is increased, e.g., after #62 #63

@cosimolupo cosimolupo closed this Jul 1, 2024
@cosimolupo cosimolupo deleted the plot_limits_PR branch July 1, 2024 13:04
@cosimolupo cosimolupo restored the plot_limits_PR branch July 1, 2024 13:06
@cosimolupo cosimolupo reopened this Jul 1, 2024
@cosimolupo cosimolupo closed this Jul 1, 2024
@cosimolupo cosimolupo deleted the plot_limits_PR branch July 1, 2024 13:08
@cosimolupo cosimolupo restored the plot_limits_PR branch July 1, 2024 13:08
@cosimolupo cosimolupo reopened this Jul 1, 2024
@mdenker mdenker merged commit 9bc48f4 into NeuralEnsemble:master Jul 18, 2024
@cosimolupo cosimolupo deleted the plot_limits_PR branch August 14, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants