-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New logic for plot limits #48
Conversation
@cosimolupo Possibly already implemented. Please check and close if duplicate. |
Possibly new PR for the change in pipeline/utils/parse.py ? |
b296bfe
to
19bab7c
Compare
Dear @mdenker, also in this case I re-aligned the branch to the current HEAD of NeuralEnsemble/cobrawap, and then added back the only changes still needed, after the introduction of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can judge, this seems fine to me.
PLOT_TSTART: 0 # float (in s) or 'None' -> T_START of the input signal is used | ||
PLOT_TSTOP: 10 # float (in s) or 'None' -> T_STOP of the input signal is used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and in the following, does T_START
refer to t_start
of the Neo object? In that case I would suggest
PLOT_TSTART: 0 # float (in s) or 'None' -> T_START of the input signal is used | |
PLOT_TSTOP: 10 # float (in s) or 'None' -> T_STOP of the input signal is used | |
PLOT_TSTART: 0 # float (in s) or 'None' -> t_start of the input signal is used | |
PLOT_TSTOP: 10 # float (in s) or 'None' -> t_stop of the input signal is used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they refer to the attributes of the neo object. I used the uppercase notation as in the config files they are introduced this way. Anyway, let's decide if switch to the lowercase version, and then I will fix them coherently.
@mdenker I adapted the description in config template files, so to make more explicit and clear what means setting PLOT_TSTART and/or PLOT_TSTOP value to 'None'. |
Merging Pull Request #61 added some extra spacings, which I fixed in a further commit. |
Changed the logic on plot limits (in config files, 'None' is now accepted as value for t_start/t_stop to plot the entire signal).