-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] #613 spike_train_generation module to handle multichannel AnalogSignal inputs #614
Merged
Moritz-Alexander-Kern
merged 20 commits into
NeuralEnsemble:master
from
INM-6:fix/#613_spike_train_generation_peak_detection
Jul 17, 2024
Merged
[Fix] #613 spike_train_generation module to handle multichannel AnalogSignal inputs #614
Moritz-Alexander-Kern
merged 20 commits into
NeuralEnsemble:master
from
INM-6:fix/#613_spike_train_generation_peak_detection
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls to peak_extraction, spike_extraction
Moritz-Alexander-Kern
changed the title
[Fix]#613 spike_train_generation module to handle multichannel AnalogSignal inputs
[Fix] #613 spike_train_generation module to handle multichannel AnalogSignal inputs
Jan 25, 2024
…tion_peak_detection
Moritz-Alexander-Kern
added
the
enhancement
Editing an existing module, improving something
label
Apr 4, 2024
…tion_peak_detection
Moritz-Alexander-Kern
merged commit Jul 17, 2024
32e1199
into
NeuralEnsemble:master
2 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #613.
This PR changes the handling of
neo.AnalogSignals
inelephant.spike_train_generation
module.Type Annotations: Improved code readability with type annotations.
Multichannel Support: handling of analog signals with multiple channels in
spike_extraction
,threshold_detection
, andpeak_detection
.New Parameter:
always_as_list
: Ensures a consistent list output of SpikeTrains, even with single-channel input.Unit Tests: testing for various input types and values to validate reliability, and multichannel AnalogSignals
Input Checks: Enhanced to catch errors related to incorrect input types.
todo: