-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] CuBIC, SPADE with scipy 1.14.0, deprecated .A
attribute in scipy.sparse
matrices`
#636
Merged
Moritz-Alexander-Kern
merged 5 commits into
NeuralEnsemble:master
from
INM-6:fix/spade_with_scipy_1_14_0
Jul 17, 2024
Merged
[Fix] CuBIC, SPADE with scipy 1.14.0, deprecated .A
attribute in scipy.sparse
matrices`
#636
Moritz-Alexander-Kern
merged 5 commits into
NeuralEnsemble:master
from
INM-6:fix/spade_with_scipy_1_14_0
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moritz-Alexander-Kern
changed the title
[Fix] SPADE with scipy 1.14.0, deprecated
[Fix] Cubic, SPADE with scipy 1.14.0, deprecated Jun 28, 2024
.A
attribute in scipy.sparse
matrices`.A
attribute in scipy.sparse
matrices`
Moritz-Alexander-Kern
changed the title
[Fix] Cubic, SPADE with scipy 1.14.0, deprecated
[Fix] CuBIC, SPADE with scipy 1.14.0, deprecated Jun 28, 2024
.A
attribute in scipy.sparse
matrices`.A
attribute in scipy.sparse
matrices`
Moritz-Alexander-Kern
requested review from
mdenker
and removed request for
mdenker
July 11, 2024 14:12
mdenker
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build wheels
Moritz-Alexander-Kern
merged commit Jul 17, 2024
0984e19
into
NeuralEnsemble:master
15 checks passed
Moritz-Alexander-Kern
added a commit
that referenced
this pull request
Oct 25, 2024
…cipy.sparse` matrices` (#636) * fix deprecated .A attribute on coo_matrix * make precision for cubic explicit * ensure float64 precision for data when using scipy.stats.kstat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue arising from the deprecation of the
.A
attribute inscipy.sparse
matrices starting withscipy==1.14.0
.The
.A
attribute was used to convert sparse matrices to densendarray
format.However, this attribute was deprecated and has been removed in favor of the more explicit
.toarray()
method.This deprecation was introduced with
scipy==1.11.0
. The PR removing it is #20499, see: scipy/scipy#20499See also release notes: https://docs.scipy.org/doc/scipy/release/1.14.0-notes.html#expired-deprecations
Changes
SPADE
Replaced the use of .A with .toarray() in the
_build_context
function in thespade
module.This change preserves the functionality of converting a
coo_matrix
to a dense format without breaking the code due to the deprecated attribute.This was done following the official recommendation, see property docstring:
Cubic
Ensure numeric precision of data ndarray is float64.
On Windows test fail with:
This seems similar to:
#227
#229