-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] add include_t_stop flag to Synchrotool class, Issue 493 #637
Open
Moritz-Alexander-Kern
wants to merge
24
commits into
NeuralEnsemble:master
Choose a base branch
from
INM-6:fix/index_error_synchrotool_493
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[ENH] add include_t_stop flag to Synchrotool class, Issue 493 #637
Moritz-Alexander-Kern
wants to merge
24
commits into
NeuralEnsemble:master
from
INM-6:fix/index_error_synchrotool_493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moritz-Alexander-Kern
added
the
enhancement
Editing an existing module, improving something
label
Jul 17, 2024
Moritz-Alexander-Kern
changed the title
[Fix] Index error synchrotool Issue 493
[ENH] add include_t_stop flag to Synchrotool class, Issue 493
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses #493.
New feature:
include_t_stop
flag inSynchrotool
classThis pull request introduces a new feature to the Synchrotool class by adding the
include_t_stop flag
. This allows users to include the end of the spike train (t_stop) in the analysis, ensuring that any spikes close tot_stop
are properly annotated.Summary of changes
include_t_stop
as a new optional boolean parameter to the Synchrotool class constructor. If set to True, the spikes close to t_stop of the spike train are included in the analysis.Examples
The following minimal example should not longer raise an index out of bounds error: