Compatibility with pyqt6 #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Salut Melodie, For PySide6 compatibility we should instead add |
|
Hi Sam,
Your suggestion to handle all qt versions from the myqt.py would indeed be much better! Yet I couldn’t find a straight forward way to do it quickly. KeyboardModifier and a few others are easy enough to deal with because they are simple submodules at the root. For QSizePolicy and QFrame however, it isn’t that simple as the « submodules » (Policy, Shape and Shadow) are actually sub-attributes so renaming the module isn’t a solution. It seems backward compatibility is easier done than the forward one. Anyway, I keep in mind to suggest something better when I find time to look into this more deeply.
See you
… Le 12 mars 2024 à 14:46, Garcia Samuel ***@***.***> a écrit :
Salut Melodie,
the PySide6 compatibility should be handle only in myqt.py.
Not in all all views!! This will be impossible to maintain if we go in this direction.
For PySide6 compatibility we should instead add QT.Qt.KeyboardModifier as submodules in the dynamic wrapper and this should works directy. Could you try that ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello (salut Sam!!)
I have added compatibility for pyqt6 since it is the version I use. It now works with my (so far very basic) usage of the library. I guess you had it commented as a possible QT_MODE because of the slightly different structure of some enums. For those (I have tried to be extensive, yet I might have missed a few), I used QT_MODE as a condition to access the right variable "path".
However, I couldn't successfully run the included pytests, as it fails quickly at the test for Neo rawio sources. I assume I don't have the right test files so I didn't worry much about this.
Please consider including the PyQt6 compatibility for your next release of the package.
All the best