Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use biometricpromt and more consistent callbacks #179

Merged
merged 57 commits into from
Nov 12, 2019
Merged

Use biometricpromt and more consistent callbacks #179

merged 57 commits into from
Nov 12, 2019

Commits on Aug 6, 2019

  1. Merge pull request #1 from NiklasMerz/master 

    Fix issue 152 (NiklasMerz#174)
    @greaterking
    greaterking authored Aug 6, 2019
    Configuration menu
    Copy the full SHA
    7b2f741 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. APP-445 

    - upgrading fingerprint to use biometric prompt
    Ralph Theart committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    aa90d42 View commit details
    Browse the repository at this point in the history

  2. APP-445 

    - renamed packages
    Ralph Theart committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    928bce6 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2019

  1. - using lib for prompt proved to be far better then trying to keep so… 

    …me old things

- removed all res/ references
    Ralph Theart committed Aug 8, 2019
    Configuration menu
    Copy the full SHA
    6b30a3b View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2019

  1. - using lib for prompt proved to be far better then trying to keep so… 

    …me old things

- removed all res/ references
    Ralph Theart committed Aug 9, 2019
    Configuration menu
    Copy the full SHA
    12ba82f View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2019

  1. - testing isAvailable

    Ralph Theart committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    4099d6b View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2019

  1. - added to .gitignore

    Ralph Theart committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    f52ba1d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/2.0.0-biometricpromt-and-consist… 

    …ent-callbacks' into 2.0.0-biometricpromt-and-consistent-callbacks
    Ralph Theart committed Aug 11, 2019
    Configuration menu
    Copy the full SHA
    1efb7f3 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2019

  1. - error codes are consistent across all platforms 

    - isAvailable can actually fail
    Ralph Theart committed Aug 15, 2019
    Configuration menu
    Copy the full SHA
    714abb1 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. - constants reminder

    Ralph Theart committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    4e36cc6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/2.0.0-biometricpromt-and-consist… 

    …ent-callbacks' into 2.0.0-biometricpromt-and-consistent-callbacks
    Ralph Theart committed Aug 16, 2019
    Configuration menu
    Copy the full SHA
    ddacc62 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2019

  1. - made description and subtitle optional in android if null is passed… 

    … they won't show

- removed onAuthenticationFail even since its better suited for use with observable not promise (can add back anytime if we feel that reported every failed attempt of a scan is needed. Most people just want success or do X when sensor is locked-out which the plugin already does)
- spelling errors fixed in tests.js
- wrote new test and adjusted current ones
- updating js interface to accommodate all new parameters
- updated readme outlining new changes in v3
- updated aar to remove unused events
- updated ionic native wrapper (unpublished atm)
- bumped version
    Ralph Theart committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    012d98f View commit details
    Browse the repository at this point in the history

  2. - removed res folder since it's not needed

    Ralph Theart committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    cb1104b View commit details
    Browse the repository at this point in the history

  3. - testing if draft pr gets updated when not in review mode

    Ralph Theart committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    fafa4df View commit details
    Browse the repository at this point in the history

  4. - trying to fix cognitive complexity stuff

    Ralph Theart committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    b41944b View commit details
    Browse the repository at this point in the history

  5. - fixing too many returns

    Ralph Theart committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    8e03551 View commit details
    Browse the repository at this point in the history

  6. License notes

    @NiklasMerz
    NiklasMerz committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    2d41eae View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into 2.0.0-biometricpromt-and-consistent-callbacks

    @NiklasMerz
    NiklasMerz authored Aug 17, 2019
    Configuration menu
    Copy the full SHA
    ce4be4c View commit details
    Browse the repository at this point in the history

  8. Fix linting error

    @NiklasMerz
    NiklasMerz committed Aug 17, 2019
    Configuration menu
    Copy the full SHA
    0796c2b View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2019

  1. - updating reademe

    Ralph Theart committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    1f358d5 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2019

  1. https://github.com/NiklasMerz/cordova-plugin-fingerprint-aio/pull/179… 

    …#discussion_r326434292

- fixing isAvailable checks
    Ralph Theart committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    02e0256 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2019

  1. - fixing else if condition

    Ralph Theart committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    5e2e4b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Upgrade android project with https://github.com/exxbrain/android-biom… 

    …etric library
    @exxbrain
    exxbrain committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    d8e5ab4 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. Update android-biometric to version 0.3

    @exxbrain
    exxbrain committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    e02a01a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2019

  1. Fix returning success message

    @exxbrain
    exxbrain committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    7861ae3 View commit details
    Browse the repository at this point in the history

  2. Add a comment why we always return "finger" in Android

    @exxbrain
    exxbrain committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    1f38c58 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #2 from exxbrain/2.0.0-biometricpromt-and-consiste… 

    …nt-callbacks

2.0.0 biometricpromt and consistent callbacks
    @greaterking
    greaterking authored Oct 12, 2019
    Configuration menu
    Copy the full SHA
    b1c4101 View commit details
    Browse the repository at this point in the history

  4. Fix compilation error

    @exxbrain
    exxbrain committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    a4374a2 View commit details
    Browse the repository at this point in the history

  5. Merge branch '2.0.0-biometricpromt-and-consistent-callbacks' into gre… 

    …atking/2.0.0-biometricpromt-and-consistent-callbacks
    @exxbrain
    exxbrain committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    682676e View commit details
    Browse the repository at this point in the history

  6. Fixed some codeclimate errors

    @exxbrain
    exxbrain committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    5922172 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #3 from exxbrain/2.0.0-biometricpromt-and-consiste… 

    …nt-callbacks

2.0.0 biometricpromt and consistent callbacks
    @greaterking
    greaterking authored Oct 12, 2019
    Configuration menu
    Copy the full SHA
    bbf24eb View commit details
    Browse the repository at this point in the history

  8. Revert "2.0.0 biometricpromt and consistent callbacks"

    @greaterking
    greaterking authored Oct 12, 2019
    Configuration menu
    Copy the full SHA
    52abe99 View commit details
    Browse the repository at this point in the history

  9. Merge pull request #4 from greaterking/revert-3-2.0.0-biometricpromt-… 

    …and-consistent-callbacks

Revert 3 2.0.0 biometricpromt and consistent callbacks
    @greaterking
    greaterking authored Oct 12, 2019
    Configuration menu
    Copy the full SHA
    2ceac63 View commit details
    Browse the repository at this point in the history

  10. Revert "Revert "2.0.0 biometricpromt and consistent callbacks"" 

    This reverts commit 52abe99.
    @exxbrain
    exxbrain committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    bbeefbb View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2019

  1. Merge pull request #5 from exxbrain/2.0.0-biometricpromt-and-consiste… 

    …nt-callbacks

Revert "Revert "2.0.0 biometricpromt and consistent callbacks""
    @greaterking
    greaterking authored Oct 13, 2019
    Configuration menu
    Copy the full SHA
    06a94e1 View commit details
    Browse the repository at this point in the history

  2. Code climate related fixes

    @exxbrain
    exxbrain committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    2f36680 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #6 from exxbrain/2.0.0-biometricpromt-and-consiste… 

    …nt-callbacks

Code climate related fixes
    @greaterking
    greaterking authored Oct 13, 2019
    Configuration menu
    Copy the full SHA
    b7bfda6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'NiklasMerz/master' into 2.0.0-biometricpromt-and-consis… 

    …tent-callbacks
    @exxbrain
    exxbrain committed Oct 13, 2019
    Configuration menu
    Copy the full SHA
    533fb2f View commit details
    Browse the repository at this point in the history

  5. Merge pull request #7 from exxbrain/2.0.0-biometricpromt-and-consiste… 

    …nt-callbacks

2.0.0 biometricpromt and consistent callbacks
    @greaterking
    greaterking authored Oct 13, 2019
    Configuration menu
    Copy the full SHA
    bdfd9f9 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. - remove mention of @anitaa1990 aar lib ..since its no longer being u… 

    …sed.
    Ralph Theart committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    177d04a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Update library to use aar file.

    Denis Zakharov committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    885ef2c View commit details
    Browse the repository at this point in the history

  2. Merge branch 'greaterking/2.0.0-biometricpromt-and-consistent-callbac… 

    …ks' into 2.0.0-biometricpromt-and-consistent-callbacks
    @exxbrain
    exxbrain committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    f7d75c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Several fixes according to code review. Upgrade to full clone of andr… 

    …oidx.biometic.
    @exxbrain
    exxbrain committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    d262c16 View commit details
    Browse the repository at this point in the history

  2. Rotation behaviour fix

    @exxbrain
    exxbrain committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    01ce93f View commit details
    Browse the repository at this point in the history

  3. Do not close dialog on fail.

    @exxbrain
    exxbrain committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    cc39ba9 View commit details
    Browse the repository at this point in the history

  4. Some refactoring

    Denis Zakharov committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    53ec6f0 View commit details
    Browse the repository at this point in the history

  5. Fix codeclimate warning

    Denis Zakharov committed Oct 16, 2019
    Configuration menu
    Copy the full SHA
    9c0ba00 View commit details
    Browse the repository at this point in the history

  6. Merge pull request #8 from exxbrain/2.0.0-biometricpromt-and-consiste… 

    …nt-callbacks

2.0.0 biometricpromt and consistent callbacks
    @greaterking
    greaterking authored Oct 16, 2019
    Configuration menu
    Copy the full SHA
    7e5ff42 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Handle BiometricPrompt.ERROR_USER_CANCELED

    Denis Zakharov committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    cee5950 View commit details
    Browse the repository at this point in the history

  2. Remove cordova-android version from tests

    Denis Zakharov committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    4518ca6 View commit details
    Browse the repository at this point in the history

  3. android-biometric.aar annotation

    Denis Zakharov committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    96397eb View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2019

  1. Merge pull request #9 from exxbrain/2.0.0-biometricpromt-and-consiste… 

    …nt-callbacks

2.0.0 biometricpromt and consistent callbacks
    @greaterking
    greaterking authored Oct 18, 2019
    Configuration menu
    Copy the full SHA
    9b594c6 View commit details
    Browse the repository at this point in the history

  2. Add "biometric" type

    Denis Zakharov committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    b2ab181 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #10 from exxbrain/2.0.0-biometricpromt-and-consist… 

    …ent-callbacks

Add "biometric" type
    @greaterking
    greaterking authored Oct 18, 2019
    Configuration menu
    Copy the full SHA
    6a64907 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. - removed all occurrences of "FINGERPRINT" in constants to make them … 

    …more generic as there are different biometric types
    Ralph Theart committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    5310c2c View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Add __cancelButtonTitle__ for Android

    @NiklasMerz
    NiklasMerz committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    f4a312b View commit details
    Browse the repository at this point in the history

  2. Gitignore Android project

    @NiklasMerz
    NiklasMerz committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    ccc8a47 View commit details
    Browse the repository at this point in the history