Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.20+ Advancements Support #106

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

VDPineapple
Copy link
Contributor

ninbotexample

Added the following features:

  • New setting to Optional features > All Advancements window: 1.20+ All Advancements Mode with more rows for 1.20+ features.
    • Stronghold: Unchanged
    • Spawn: Unchanged
    • Outpost: Activates with F3+C when 63 >= Y < 160
    • Monument: Activates with F3+C when 30 > Y < 63
    • Shrieker: Activates with F3+C when Y <= 30. 1.20+ runs need to transport a warden back to spawn.
    • End City: Activates with F3+C when in the end. 1.21 runs usually transport shulker after initial end entry with leading boats.
    • Ancient City Region Centres: Activates with F3+C when Y > 160. Ancient city regions are centred around 24m+8 chunk coordinates, where m is an integer. This helps find the closest ancient city region centre to improve dig-down odds.
    • General Location: Activates with F3+I when all advancements mode is toggled. Useful when you need a temporary coordinate written down which you will return to in the short-term. Typical scenarios include ancient city dig-down spots, tadpole spawning spot, foxes.

Known side effects:

  • New MCDimension class instead of inNether booleans.
  • To make space for the new rows, allowed the allAdvancements panel to use its preferred size. This changes the regular allAdvancements panel height, making it slightly bigger.
  • Not much space to add the instructions for when each structure-type triggers, so there are no new instructions in the program itself.
  • Due to the length of 1.20+ runs, they are often done in multiple segments, which will wipe the bot. It may be helpful to write coordinates in a file in the world folder at some point in the future.

}
}

public void generalLocationSet(StructurePosition structurePosition) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove, generalLocationSet is unused right?

@VDPineapple
Copy link
Contributor Author

Thanks for your feedback, I've fixed all of the things you mentioned. I also fixed the remove button for the new structures. Let me know if you'd like any further changes.

@Ninjabrain1 Ninjabrain1 merged commit 12f4b7a into Ninjabrain1:main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants