Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfs: 0.13.0 -> 0.13.1 #180999

Merged
merged 3 commits into from
Jul 11, 2022
Merged

ipfs: 0.13.0 -> 0.13.1 #180999

merged 3 commits into from
Jul 11, 2022

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jul 10, 2022

Description of changes

https://github.com/ipfs/go-ipfs/releases/tag/v0.13.1
Also disable the FUSE test, since the FUSE mount functionality of IPFS is currently broken, see ipfs/kubo#9044.

ipfshttpclient fails to build but this was already the case with IPFS 0.13.0.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

The `repoVersion` is only used outside the derivation and not for the build of IPFS itsef. This is exactly the use-case `passthru` was meant for.
It allows updating the `repoVersion` without rebuilding IPFS. This may come in handy if someone forgets to update it and it needs to be updated later.
The FUSE mount functionality of IPFS was broken by the update to v0.13.0, so disable it. Hopefully it will be fixed soon.
See ipfs/kubo#9044.
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jul 10, 2022
@ofborg ofborg bot requested review from kalbasit and fpletz July 10, 2022 17:28
@fpletz fpletz merged commit d048693 into NixOS:master Jul 11, 2022
@Luflosi Luflosi deleted the update/ipfs branch July 11, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants