Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: fix starting containers with a local connection #244290

Merged

Conversation

LeSuisse
Copy link
Contributor

@LeSuisse LeSuisse commented Jul 19, 2023

Description of changes

Fixes #244159

Issue is caused by a fix in Go 1.20.6, see upstream issue moby/moby#45935

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 244290 run on x86_64-linux 1

18 packages built:
  • apptainer
  • apptainer-overriden-nixos
  • apx
  • charliecloud
  • docker (docker_20_10)
  • docker-gc
  • docker.man (docker_20_10.man)
  • fn-cli
  • nvidia-docker
  • pipework
  • python310Packages.jupyter-repo2docker
  • python310Packages.jupyter-repo2docker.dist
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

Fixes NixOS#244159

Issue is caused by a fix in Go 1.20.6, see upstream issue
moby/moby#45935
@LeSuisse
Copy link
Contributor Author

I'm taking a look but we might need to also patch docker-compose docker/compose#10810

@LeSuisse
Copy link
Contributor Author

A new version of docker-compose was already released, see #244013 so no need to patch an upgrade will be enough (for master at least)

Copy link
Contributor

@amaxine amaxine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if 23.05 backports were being taken care of for docker, so that might need doing by hand.

@LeSuisse
Copy link
Contributor Author

23.05 is also at 20.10.23 and from quick glance the automatic backport should work.

@SuperSandro2000 SuperSandro2000 merged commit 3940a4c into NixOS:master Jul 19, 2023
11 of 12 checks passed
@LeSuisse LeSuisse deleted the fix-local-build-docker-go-1.20.6 branch July 19, 2023 09:44
@github-actions
Copy link
Contributor

Successfully created backport PR for release-23.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker fails to run containers
3 participants