Add --add-rpath-and-shrink option to do both operations in one go
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The core issue is that `--shrink-rpath` doesn't free up space filled with `X` by `--add-rpath`, so using a combination of `--add-rpath` & `--shrink-rpath` on a virtual env will blow up shared libraries and cause them to segfault when loaded by Python at some point.
|
@Ma27 I can probably just give you merge access to this project. |
|
Feel free to go ahead with this pull request: https://github.com/orgs/NixOS/teams/patchelf-maintainers/members |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I know this is missing an update of the man-page and tests. I'd like to know if you'd be open to accept such a patch in the first place before investing more time into it.
The core issue is that
--shrink-rpathdoesn't free up space filledwith
Xby--add-rpath, so using a combination of--add-rpath&--shrink-rpathon a virtual env will blow up shared libraries andcause them to segfault when loaded by Python at some point.
This is not an issue with Nix builds, but it absolutely is when using this
in an imperatively managed virtualenv.
cc @Mic92
Thank you!
Please do your best to include a regression test
so that the quality of future releases can be preserved.