Arbitrary Lagrangian-Eulerian (ALE) code refactorization #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate modules for vertical coordinate data/routines and ALE regridding/remapping. - Added support for an additional vertical coordinate, vcoord = 'plevel', that uses the ALE method. - Reference potential densities and pressure levels can optionally be provided via namelist for vcoord = 'cntiso_hybrid' and vcoord = 'plevel'. - The ALE regridding and remapping has been overhauled to allow more choices to controoled by namelist variables and to make the code more extensible.
|
@matsbn , @mvertens |
|
@TomasTorsvik - thanks for doing these tests! I'm surprised that baselines are missing. What I have found is that if my laptop goes to sleep while the tests are running then my session on betzy stops and the tests don't complete. Hopefully, all the new baselines are now there with noresm2_5_alpha04. |
|
Here is the log for the failed run test: |
|
I get the same RUN error from ERS_Ld3.TL319_tn05.NOIIAJRA.betzy_intel.blom-hybrid when running |
TomasTorsvik
approved these changes
Aug 30, 2024
|
With the xcspmd error in the log, @TomasTorsvik , it seems the CPP flag ARCTIC is incorrectly not defined (leading to use_ARCTIC = .false.). |
|
@matsbn - Would it be sufficient to add the |
|
You're right, @TomasTorsvik . These cppdefs for the |
Thanks for the heads-up, @TomasTorsvik . I will have a look at it and update the PR. Would be good to get this merged to master soon as further developments will build on this refactorization. |
|
@matsbn - I have renamed mod_nuopc_methods.F90 to ocn_import_export.F90 to be consistent with other component nuopc cap code. |
|
Conflicts have been resolved, along with some formatting and the ability to build without iHAMOCC when using MCT. I still get bitidentical results with current master. |
|
@matsbn - I looked briefly through the last changes. I don't think there is need for a new code review, so you can merge this to master if you think it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of the ALE method implementation that involves:
The code is tested in NorESM2.0.6 and gives bit-identical results in N2NOIIAJRAOC20TR compset with TL319_tn14 grids for both vcoord = 'isopyc_bulkml' and vcoord = 'cntiso_hybrid', using default namelist settings.