Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remain with cyanobacteria only in euphotic zone. #396

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

jmaerz
Copy link
Collaborator

@jmaerz jmaerz commented Sep 10, 2024

closes #395

@jmaerz jmaerz added the iHAMOCC Issue mainly concerns the iHAMOCC code base label Sep 10, 2024
@jmaerz jmaerz added this to the NorESM2.5 - BLOM/iHAMOCC milestone Sep 10, 2024
@jmaerz jmaerz self-assigned this Sep 10, 2024
Copy link
Contributor

@TomasTorsvik TomasTorsvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmaerz - looks fine to me

@@ -75,7 +75,7 @@ subroutine cyano(kpie,kpje,kpke,kbnd,pddpo,omask,ptho)
do j=1,kpje
do i=1,kpie
if (omask(i,j) > 0.5) then
do k=1,merge(kwrbioz(i,j),kmle(i,j),leuphotic_cya) ! if leuphotic_cya=.true., do bluefix only in euphotic zone
do k=1,kwrbioz(i,j) ! if leuphotic_cya=.true., do bluefix only in euphotic zone
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
do k=1,kwrbioz(i,j) ! if leuphotic_cya=.true., do bluefix only in euphotic zone
do k=1,kwrbioz(i,j) ! do bluefix only in euphotic zone

The comment on this line can also be changed (or removed)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recognized it, when you approved :-) - sorry for that. Done.

Copy link
Contributor

@JorgSchwinger JorgSchwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you, looks good to me!

@jmaerz jmaerz merged commit 53b8173 into NorESMhub:master Sep 10, 2024
5 checks passed
@jmaerz jmaerz deleted the cya-only-in-euphotic branch September 10, 2024 14:37
@jmaerz jmaerz mentioned this pull request Sep 12, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iHAMOCC Issue mainly concerns the iHAMOCC code base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove MLD switch for cyanobacteria - making euphotic zone N2 uptake remaining default
3 participants