-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bokeh app and version/dependency updates #85
Conversation
lasseke
commented
Feb 28, 2022
- Updated the bokeh app to enable making and running cases from a settings file via a simple interactive browser interface
- Changed platform package version to 0.1.0 (will be used to name case/input/run folders, too)
- Updated previously discovered dependency issues, which might overlap with @ka7eh 's recent PR Docker updates #76
from bokeh.models.widgets import TextInput, Button, Paragraph | ||
from bokeh.events import ButtonClick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the code in docker and faced 2 issues, which are not relevant outside of docker, but it's good to mention now.
First, USER
env var is not set, which is required by create_newcase
(I'm not sure why. This should be available by default). This can be fixed by importing os
and adding the following line after the imports: os.environ['USER'] = subprocess.run(['whoami'], stdout=PIPE).stdout.decode('utf-8').strip()
.
The second issue is about data
folder permissions inside docker, though we can ignore this for now. I think it's easier to merge this first and then fix this issue so we can test everything together with the latest docker changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Kaveh! I'll merge it for now then so that everyone can easily test the new adaptations. There is also one UX issue with executing multiple call-backs in the bokeh up simultaneously, I will show what I mean during our meeting and open a GH issue later.